copyright を 2018 に変更 #232
Merged
copyright を 2018 に変更 #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berryzplus
approved these changes
Jul 8, 2018
| @@ -34,7 +34,7 @@ LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT | |||
| #pragma code_page(932) | |||
| #endif //_WIN32 | |||
|
|
|||
| #define S_COPYRIGHT "Copyright (C) 2011-2017 by Lucien & Collaborators" | |||
| #define S_COPYRIGHT "Copyright (C) 2011-2018 by Lucien & Collaborators" | |||
There was a problem hiding this comment.
PR内容とは関係ないですが・・・。
いつかどこかで話さないといけないトピック。
翻訳じゃなくて著作者変わっとるやんけ、という話。
There was a problem hiding this comment.
There was a problem hiding this comment.
今内容を把握。dll のほうの著作者かと思ってましたが、よく確認してみたらサクラエディタ本体ダイアログの Copyright が変わっちゃう所でしたね。たしかにこれは問題。（とはいえやはりどのような書き方が好ましいのか分かってない）
There was a problem hiding this comment.
http://d.hatena.ne.jp/sardine/20060912
Copyright of the original © 2004-2006 W3C® (MIT, ERCIM, Keio), All Rights Reserved. Translated by [ここに翻訳者名]. W3C liability, trademark and document use rules apply for the original and the translation."
みたいな？
|
バージョンダイアログの表示が 2018 に変わっていることを確認。
|
|
exe, dll のプロパティ側の表示も 2018 に変わったことを確認。
|
Closed
|
＞ @m-tmatma さん、およびみなさん 自分は最初 exe, dll のプロパティのみ変更されるものと思い込んでしまっていましたが、よくよく見たらバージョンダイアログ表示も変わっていることに後から気づきました。 |
kobake
approved these changes
Jul 8, 2018
リソース DLL しか変更されないつもりでした。 |
#233 を登録しました。 |
|
あらためまして、新年あけましておめでとうございます 😄 |
Merged
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 11, 2019
…2018 copyright を 2018 に変更
Merged
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copyright を 2018 に変更