Json decode error (too many inputs) #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @Maarten-vd-Sande! I will pass it through some quick tests and also check what is going on with ENA links - thanks for bringing it to my attention |
Closed
|
Sorry for not being able to catch up with this @Maarten-vd-Sande. I am not quite sure why the tests fail, I will try to take a look at it this week. |
|
No problem @saketkc! I'm guessing I messed up the indentation somewhere. If I have time somewhere coming week(s) I'll try to take a look at it as well |
|
Closing because of conflicts with the current master. We can reopen if there is still interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve #78, as per the suggestion of @kpj. Requests simply get split up into smaller parts of 150, logic for the rest is untouched. @saketkc would this be something you are willing to support? It seems to work for me. There are a couple of cases that I am not sure about how to deal with, i put comments for those.
Unrelated, but not sure if I remember correctly so I put it here before I make an issue: I saw a couple weeks ago that ENA changed their API, and all the
ena_fastq_httplinks arenaneven for ERR accessions from pysradb.