gcd and lcm of isogenies of Drinfeld modules#40434
Merged
vbraun merged 23 commits intosagemath:developfrom Aug 27, 2025
Merged
Conversation
Contributor
|
Hi @fchapoton. It seems the documentation build is failing but we reckon it's not a problem on our side (something to do with artifacts). What should we do about it? |
5 tasks
Contributor
|
I have no idea, sorry. Ignore it and do your best to write correct docs. EDIT: you can also build the doc locally, maybe. It takes several hours for the full doc, but you can restrict to the "document" that you are changing. |
Contributor
Author
|
I built the documentation and it looks fine. |
Contributor
|
the reason the doc build fails is #40379 . Just ignore it for now. |
|
Documentation preview for this PR (built with commit 43a7920; changes) is ready! 🎉 |
kryzar
reviewed
Aug 11, 2025
Contributor
kryzar
left a comment
kryzar
left a comment
There was a problem hiding this comment.
Only one comment (in the review directly).
kryzar
approved these changes
Aug 12, 2025
kryzar
approved these changes
Aug 13, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 13, 2025
sagemathgh-40434: gcd and lcm of isogenies of Drinfeld modules We add methods to compute right gcds and left lcms of isogenies between Drinfeld modules. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430 URL: sagemath#40434 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière
github-actions
bot
added
s: needs review
and removed
s: positive review
s: needs work
labels
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 21, 2025
sagemathgh-40434: gcd and lcm of isogenies of Drinfeld modules We add methods to compute right gcds and left lcms of isogenies between Drinfeld modules. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430 URL: sagemath#40434 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We add methods to compute right gcds and left lcms of isogenies between Drinfeld modules.
📝 Checklist
⌛ Dependencies
#40430