Fix docbuilding on release tag#40379
Conversation
… build" This reverts commit 90392d8.
cc5dfd4 to
f59a6fd
Compare
|
do try to open a pull request on your repository to see that the diff is correctly processed. |
|
It randomly fails with in the 'livedoc' building. I don't have time right now to investigate this further and thus temporarily disabled the live doc building. https://github.com/tobiasdiez/sage/actions/runs/16137723269 |
|
I guess if it works sometimes it's still better than it fails all of the time (?) |
|
I run it a couple of times, and it was always failing - but the "sub-docs" that triggered this error was always different. |
Maybe try disabling parallelism? (Better slow than broken?) |
|
Sure, that's a good approach to fix it. I don't have the time to work on this in the next two weeks (and this PR was meant more as quick hotfix), but will investigate it more afterwards... |
|
The live docs issue is tracked at #40463. Could we please get this is to have the docbuild run in GH finally pass again? |
|
I wish these long generated yml files are not getting in the way, but OK. |
|
What does livedoc mean? Besides, what is the effect of this pull request?
|
That's a mode where you can edit the example in the browser and rerun it, see the "Sage Live" tab on https://doc-release--sagemath.netlify.app/html/en/a_tour_of_sage/. This is not used (yet?) on the official sage website.
It fixes the doc build action run that is triggered after a new release (and such a successful run is needed to have the docbuild runs for PRs succeed). -- @dimpase Thanks for the review. I've now merged #40383 (and rerun For later reference, updating the compilers needs new givaro and for this first conda-forge/fflas-ffpack-feedstock#21. |
|
updating compilers? |
In conda, gcc v14 is not working (due to some issues in givaro 4.2.0; 4.2.1 is already on conda but then there are issues with fflas conda-forge/fflas-ffpack-feedstock#21). Sage-the-distro is not affected. |
|
can you merge this into |
sagemathgh-40379: Fix docbuilding on release tag <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> After sagemath#39973, some necessary steps during the docbuild on release tags are no longer run (see https://github.com/sagemath/sage/actions/runs/161 00707903/job/45429461356). Sorry - that was my fault. This is fixed here. Test run: https://github.com/tobiasdiez/sage/actions/runs/16323033505/jo b/46105684396 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#40383 URL: sagemath#40379 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
sagemathgh-40379: Fix docbuilding on release tag <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> After sagemath#39973, some necessary steps during the docbuild on release tags are no longer run (see https://github.com/sagemath/sage/actions/runs/161 00707903/job/45429461356). Sorry - that was my fault. This is fixed here. Test run: https://github.com/tobiasdiez/sage/actions/runs/16323033505/jo b/46105684396 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#40383 URL: sagemath#40379 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
sagemathgh-40379: Fix docbuilding on release tag <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> After sagemath#39973, some necessary steps during the docbuild on release tags are no longer run (see https://github.com/sagemath/sage/actions/runs/161 00707903/job/45429461356). Sorry - that was my fault. This is fixed here. Test run: https://github.com/tobiasdiez/sage/actions/runs/16323033505/jo b/46105684396 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#40383 URL: sagemath#40379 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
sagemathgh-40379: Fix docbuilding on release tag <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> After sagemath#39973, some necessary steps during the docbuild on release tags are no longer run (see https://github.com/sagemath/sage/actions/runs/161 00707903/job/45429461356). Sorry - that was my fault. This is fixed here. Test run: https://github.com/tobiasdiez/sage/actions/runs/16323033505/jo b/46105684396 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#40383 URL: sagemath#40379 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
sagemathgh-40379: Fix docbuilding on release tag <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> After sagemath#39973, some necessary steps during the docbuild on release tags are no longer run (see https://github.com/sagemath/sage/actions/runs/161 00707903/job/45429461356). Sorry - that was my fault. This is fixed here. Test run: https://github.com/tobiasdiez/sage/actions/runs/16323033505/jo b/46105684396 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#40383 URL: sagemath#40379 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
sagemathgh-40586: Revive doc-release On every release, "doc-release" (full sage documentation with live examples and pdf docs) had been published. That was broken by sagemath#40379. The up-to-date doc-release was available through the Documentation section of the [Wiki](https://github.com/sagemath/sage/wiki). Currently available doc-release was manually uploaded by me. By the way, "doc-release" is also essential for "other version" selector (see below the Sage logo on the left panel) to work. It is currently broken. Note that "doc-release" is the source of "other versions" info. See https://doc-release--sagemath.netlify.app/html/en/versions.txt. Now doc-release is built in the doc-build-pdf workflow, and published in the new doc-publish-pdf workflow, separated from the doc-publish workflow. Test run: doc-build-livedoc: https://github.com/kwankyu/sage/actions/runs/17295972262 doc-publish-livedoc: https://github.com/kwankyu/sage/actions/runs/17298223187 Deployed doc-release: https://doc-release--sagemath-test.netlify.app/html/en/reference/ (currently broken in meson build of live doc) Try "Sage Live" tabs at https://doc-release--sagemath- test.netlify.app/html/en/reference/plot3d/sage/plot/plot3d/plot3d Fixes sagemath#40463. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40586 Reported by: Kwankyu Lee Reviewer(s): Dima Pasechnik, Kwankyu Lee, user202729
sagemathgh-40586: Revive doc-release On every release, "doc-release" (full sage documentation with live examples and pdf docs) had been published. That was broken by sagemath#40379. The up-to-date doc-release was available through the Documentation section of the [Wiki](https://github.com/sagemath/sage/wiki). Currently available doc-release was manually uploaded by me. By the way, "doc-release" is also essential for "other version" selector (see below the Sage logo on the left panel) to work. It is currently broken. Note that "doc-release" is the source of "other versions" info. See https://doc-release--sagemath.netlify.app/html/en/versions.txt. Now doc-release is built in the doc-build-pdf workflow, and published in the new doc-publish-pdf workflow, separated from the doc-publish workflow. Test run: doc-build-livedoc: https://github.com/kwankyu/sage/actions/runs/17295972262 doc-publish-livedoc: https://github.com/kwankyu/sage/actions/runs/17298223187 Deployed doc-release: https://doc-release--sagemath-test.netlify.app/html/en/reference/ (currently broken in meson build of live doc) Try "Sage Live" tabs at https://doc-release--sagemath- test.netlify.app/html/en/reference/plot3d/sage/plot/plot3d/plot3d Fixes sagemath#40463. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40586 Reported by: Kwankyu Lee Reviewer(s): Dima Pasechnik, Kwankyu Lee, user202729
After #39973, some necessary steps during the docbuild on release tags are no longer run (see https://github.com/sagemath/sage/actions/runs/16100707903/job/45429461356). Sorry - that was my fault. This is fixed here.
Test run: https://github.com/tobiasdiez/sage/actions/runs/16323033505/job/46105684396
📝 Checklist
⌛ Dependencies