Apply sort and filter of walk_packages consistently#39498
Merged
vbraun merged 1 commit intosagemath:developfrom Feb 21, 2025
Merged
Apply sort and filter of walk_packages consistently#39498vbraun merged 1 commit intosagemath:developfrom
vbraun merged 1 commit intosagemath:developfrom
Conversation
5 tasks
3 tasks
|
Documentation preview for this PR (built with commit 4b24524; changes) is ready! 🎉 |
tobiasdiez
reviewed
Feb 12, 2025
Contributor
tobiasdiez
left a comment
tobiasdiez
left a comment
There was a problem hiding this comment.
The changes look good to me, but there are a lot of time outs in the CI. Any idea what's going on?
Contributor
Author
|
Likely unknown unrelated bug, first time I see it was #39237 (comment) (another time at #39142 (comment) ) Maybe some modification in |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2025
sagemathgh-39423: Use import_module instead of find_spec Otherwise the test would fail with meson editable install. See https://g ithub.com/sagemath/sage/actions/runs/13003203795/job/36265539648 . Looks like the function was last changed in sagemath#36407. There was no discussion why the simple implementation is not used. This is part of the fix for this test. The other part needed is sagemath#39498 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. (can't really test, but see sagemath#39369) - [ ] I have updated the documentation and checked the documentation preview. (no documentation change) ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39423 Reported by: user202729 Reviewer(s): Tobias Diez
Contributor
|
Okay, thanks for the explanation! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 21, 2025
sagemathgh-39423: Use import_module instead of find_spec Otherwise the test would fail with meson editable install. See https://g ithub.com/sagemath/sage/actions/runs/13003203795/job/36265539648 . Looks like the function was last changed in sagemath#36407. There was no discussion why the simple implementation is not used. This is part of the fix for this test. The other part needed is sagemath#39498 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. (can't really test, but see sagemath#39369) - [ ] I have updated the documentation and checked the documentation preview. (no documentation change) ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39423 Reported by: user202729 Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 9, 2025
sagemathgh-39369: Test pip editable install with meson Tests pip editable install with meson on GitHub Actions. This uncovers several failing tests, which are fixed by (see dependencies below) Note: review is hard because of the large number of dependencies. It is probably easier to look only in `.github` folder. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. ### ⌛ Dependencies - sagemath#39423 - sagemath#39498 - sagemath#39494 - sagemath#39424 - sagemath#39275 - sagemath#39499 URL: sagemath#39369 Reported by: user202729 Reviewer(s): Tobias Diez, user202729
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the sorting and filtering is only applied in case of FileFinder. This makes it consistently applied.
Needed to make tests in #39369 pass.
📝 Checklist
⌛ Dependencies