Specify use_sources=True in cython compilation#39275
Specify use_sources=True in cython compilation#39275vbraun merged 6 commits intosagemath:developfrom
Conversation
|
Documentation preview for this PR (built with commit 6478f43; changes) is ready! 🎉 |
|
has this fixed any failing tests? |
|
for some reason (probably some path coincidence or whatever) it works fine on CI either way. Maybe I should figure out some way to test it on CI. |
|
Please post an explicit example of what fails for you, and the specifics of your Cython setup. |
|
Okay here it is: if e.g. Side note, do you think it's desirable to test all combinations (Python 3.11, 12 × editable: true, false) each pull request? Or we could cut down to only test e.g. {Python 3.11 non-editable, Python 3.12 editable} on pull request and test the full matrix in pushes to branch. |
|
There's a bunch of additional things that fail with Maybe we can just merge the first commit in and enable |
tobiasdiez
left a comment
There was a problem hiding this comment.
Okay, why not if it's works better.
sagemathgh-39275: Specify use_sources=True in cython compilation In my testing, this allows cython compilation of code with `from sage.[...] cimport [...]` to work when built with meson. Ability to compile cython code when use legacy build system is unaffected. Actually without this change cython compilation works fine on conda & meson CI anyway (probably because of some coincidence, I didn't inspect) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39275 Reported by: user202729 Reviewer(s): Tobias Diez
sagemathgh-39275: Specify use_sources=True in cython compilation In my testing, this allows cython compilation of code with `from sage.[...] cimport [...]` to work when built with meson. Ability to compile cython code when use legacy build system is unaffected. Actually without this change cython compilation works fine on conda & meson CI anyway (probably because of some coincidence, I didn't inspect) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39275 Reported by: user202729 Reviewer(s): Tobias Diez
sagemathgh-39369: Test pip editable install with meson Tests pip editable install with meson on GitHub Actions. This uncovers several failing tests, which are fixed by (see dependencies below) Note: review is hard because of the large number of dependencies. It is probably easier to look only in `.github` folder. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. ### ⌛ Dependencies - sagemath#39423 - sagemath#39498 - sagemath#39494 - sagemath#39424 - sagemath#39275 - sagemath#39499 URL: sagemath#39369 Reported by: user202729 Reviewer(s): Tobias Diez, user202729
In my testing, this allows cython compilation of code with
from sage.[...] cimport [...]to work when built with meson. Ability to compile cython code when use legacy build system is unaffected.Actually without this change cython compilation works fine on conda & meson CI anyway (probably because of some coincidence, I didn't inspect)
📝 Checklist
⌛ Dependencies