Skip to content

Refactor produce_latex_macro#39184

Merged
vbraun merged 3 commits intosagemath:developfrom
user202729:python-313-locals-2
Jan 18, 2025
Merged

Refactor produce_latex_macro#39184
vbraun merged 3 commits intosagemath:developfrom
user202729:python-313-locals-2

Conversation

@user202729
Copy link
Contributor

@user202729 user202729 commented Dec 22, 2024

Alternative to #39181 .

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes. (no behavior change)
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@user202729 user202729 marked this pull request as ready for review December 22, 2024 09:25
@github-actions
Copy link

github-actions bot commented Dec 22, 2024

Documentation preview for this PR (built with commit f3208ef; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@antonio-rojas
Copy link
Contributor

Much cleaner

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 23, 2024
Alternative to sagemath#39181 .

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes. (no behavior change)
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

URL: sagemath#39184
Reported by: user202729
Reviewer(s):
@tornaria
Copy link
Member

tornaria commented Jan 5, 2025

I think when you merge develop, the bot reverts the positive review so you have to re add it. I guess it's meant for cases when you actually change the PR, but merging develop should be ok.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 7, 2025
sagemathgh-39184: Refactor produce_latex_macro
    
Alternative to sagemath#39181 .

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes. (no behavior change)
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39184
Reported by: user202729
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 7, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib
    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 9, 2025
sagemathgh-39184: Refactor produce_latex_macro
    
Alternative to sagemath#39181 .

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes. (no behavior change)
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39184
Reported by: user202729
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 9, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib
    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 10, 2025
sagemathgh-39184: Refactor produce_latex_macro
    
Alternative to sagemath#39181 .

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes. (no behavior change)
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39184
Reported by: user202729
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 10, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib
    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 12, 2025
sagemathgh-39184: Refactor produce_latex_macro
    
Alternative to sagemath#39181 .

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes. (no behavior change)
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39184
Reported by: user202729
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 12, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib
    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 16, 2025
sagemathgh-39184: Refactor produce_latex_macro
    
Alternative to sagemath#39181 .

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes. (no behavior change)
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39184
Reported by: user202729
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 16, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib
    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 17, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib
    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
@vbraun vbraun merged commit ba0e89a into sagemath:develop Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants