Skip to content

Don't use count as a positional argument in re.sub#39145

Merged
vbraun merged 2 commits intosagemath:developfrom
antonio-rojas:re.sub
Dec 22, 2024
Merged

Don't use count as a positional argument in re.sub#39145
vbraun merged 2 commits intosagemath:developfrom
antonio-rojas:re.sub

Conversation

@antonio-rojas
Copy link
Contributor

This is deprecated in Python 3.13 and the warnings break tests

This is deprecated in Python 3.13 and the warnings break tests
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@github-actions
Copy link

Documentation preview for this PR (built with commit 9829c71; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 19, 2024
sagemathgh-39145: Don't use count as a positional argument in re.sub
    
This is deprecated in Python 3.13 and the warnings break tests
    
URL: sagemath#39145
Reported by: Antonio Rojas
Reviewer(s): Frédéric Chapoton
@vbraun vbraun merged commit 7963db9 into sagemath:develop Dec 22, 2024
@antonio-rojas antonio-rojas deleted the re.sub branch December 22, 2024 18:57
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 7, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib
    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 9, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib
    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 10, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib
    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 12, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib
    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 16, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib
    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 17, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib
    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants