Bundle sage-setup in sagemath-bliss#38736
Closed
tobiasdiez wants to merge 4 commits intosagemath:developfrom
Closed
Bundle sage-setup in sagemath-bliss#38736tobiasdiez wants to merge 4 commits intosagemath:developfrom
tobiasdiez wants to merge 4 commits intosagemath:developfrom
Conversation
|
Documentation preview for this PR (built with commit 66010d2; changes) is ready! 🎉 |
Contributor
Author
|
Surpassed by #38836. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #37857 it is no longer possible to install and use bliss as part of the standard build of sagelib. One is supposed to install instead the
sagemath-blissdistro package after installing sagelib. However, doing so fails withOne somehow needs to install sage_setup, sage_environment, sage_conf and perhaps a bunch of other
sage_xyzmodules, although one just succesuflly build and installed sagelib.We make
sagemath-blisseasier to install by replacing these build time dependencies with simply withsagemath_standardand bundlesage_setup. This is similar to #37287.I may add that one should probably also add
sagemath-standardunderproject.dependencies, at least I fail so see how one would use the methods of thesagemath-blissmodule without constructing a sage graph first. But that's something for a follow-up.To test:
I've added such tests to conda.
Follow-ups: do this similarly for the other modules.
📝 Checklist
⌛ Dependencies
#38556