Revert cysignals build constraint#38556
Merged
vbraun merged 1 commit intosagemath:developfrom Sep 29, 2024
Merged
Conversation
Reverts sagemath@95428a1 which broke the conda ci.
Merged
5 tasks
|
Documentation preview for this PR (built with commit 0166cab; changes) is ready! 🎉 |
Contributor
Author
|
Thanks @dimpase for the quick review. Tests are passing (Conda (macos-latest) failure is already there in main branch) > marking as ci fix to directly apply to other PRs as well. |
Contributor
|
One does not revert without doing due diligence on why the change was made etc. |
Member
|
the changes by @mkoeppe were not taking into account the needs of sagelib package maintainers, that's why parts of them need to be reversed |
Contributor
|
We have set this PR to disputed; participants may set it to positive review by counting votes in accordance with the disputed PR policy. |
Contributor
Author
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts 95428a1 which broke the conda ci.
📝 Checklist
⌛ Dependencies