pkgs/sagemath-standard: Remove self-reference at build time#37292
pkgs/sagemath-standard: Remove self-reference at build time#37292mkoeppe wants to merge 4 commits intosagemath:developfrom
Conversation
…c/pyproject.toml (fixup)
… instead of manipulating sys.path
|
Documentation preview for this PR (built with commit 8a09d7c; changes) is ready! 🎉 |
|
With these changes, how do you pip install the monolithic sagelib (ie the one independent of any modularized distributions)? |
There is no change regarding this. |
It seems that only pkgs/sagemath-standard is published on pypi, not the one in src. And since you break the smylink it now matters. |
That's right.
What matters? |
|
It matters for the following. Right now it is possible to install the monolithic sagelib distribution via pip, with your changes this is no longer possible.
|
Nonsense. |
|
@kiwifb Please review |
kiwifb
left a comment
There was a problem hiding this comment.
Looks good to me. It will not change anything from the sdist point of view as far as I can tell. If we are going to split things, I certainly want us to eat our own dog food and see stuff like pyproject-monolithic.toml.m4 going out as quickly as possible.
That's right, avoiding the self-ref is just a cleanup. |
You then might want to explain how a user would install it then from pypi (that you can still checkout the code and use the pyproject.toml from src is obvious). |
|
#37261 has updated the PyPI install instructions in our README.md, waiting for review. I'll mark it as a dependency |
|
This is now obsolete as we are not building any of these distributions. |
As explained in #37287 (comment), we make sagemath-environment a build requirement of
pkgs/sagemath-standard.The monolithic build system in
SAGE_ROOT/srcis left unchanged.📝 Checklist
⌛ Dependencies
README.md: Improve PyPI install instructions #37261setup.py: Removelazy_import_cacheuse #37432PIP_CONSTRAINT=$SAGE_ROOT/constraints_pkgs.txt#37434