setup.py: Remove lazy_import_cache use#37432
Merged
vbraun merged 3 commits intosagemath:developfrom Mar 31, 2024
Merged
Conversation
Member
|
Moving something that is only useful for sage the distro into spkg-install.in and removing it from setup.py? Sounds like a no-brainer, I do not want that stuff in my packages. |
Contributor
Author
Most likely it's not useful for anything, distro or not. Just keeping it out of excessive caution. |
kiwifb
approved these changes
Feb 23, 2024
Contributor
Author
|
Thank you! |
Member
|
merge conflict |
Contributor
Author
|
Trivial rebase. |
|
Documentation preview for this PR (built with commit b2a56e2; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 30, 2024
sagemathgh-37433: src/sage/misc/lazy_import.pyx: Deprecate star imports <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> This is an outdated feature no longer in use in the Sage library. See sagemath#37432 for details. <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37433 Reported by: Matthias Köppe Reviewer(s): Frédéric Chapoton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Checklist
Both versions of the sagelib
setup.pyhave code that tries to remove the "lazy import cache".The file name of the lazy import cache in
~/.sageis keyed toSAGE_LIB, so any file name determined at build time is meaningless at runtime when installation goes through wheel building. We remove this code.As
find ~/.sage -name "*-lazy_import*" | xargs ls -latshows, it has not been in use since 2021, as the Sage library no longer uses anylazy_importof*. But just in case some downstream / user code uses it, we reinstate the cache removal code inbuild/pkgs/sagelib/spkg-install.inWe deprecate the feature in #37433.
⌛ Dependencies