test: increase CU limit for failing tests#88
Conversation
refactor: change verification order at Stream Creation (motivation: previously, passing an endTime < startTime resulted in the CliffTimeNotLessThanEndTime error being returned) chore: update bun dependencies
| } | ||
|
|
||
| // Check: the start time is strictly less than the end time. | ||
| if start_time >= end_time { |
There was a problem hiding this comment.
the motivation for placing this check after the cliff one in the EVM contract is to keep them in chronological order (assuming that the invariant is respected: start > cliff > end)
i don't have a strong preference here, but i'd say to sync them
There was a problem hiding this comment.
The problem with the current approach is that when the timestamps are endTime < startTime < cliffTime, instead of the logical StartTimeNotLessThanEndTime error, the CliffTimeNotLessThanEndTime error is being thrown. The latter makes the function caller think that it's the relative position of endTime and cliffTime (and not endTime and startTime) that is to be fixed 🤔
There was a problem hiding this comment.
latter makes the function caller think that it's the relative position of endTime and cliffTime (and not endTime and startTime) that is to be fixed
i don't think there is a "logical" one here - they both need to be fixed not only start. IMO there is no winning candidate here
we can leave like this
There was a problem hiding this comment.
Ok, we can get back to this discussion in the future, if we find strong(-er) arguments for one order (of checks) or the other.
Merging.
chore: update Anchor version chore: remove the bytemuck dependency hotfix chore: update other dependencies test: increase CU limit for failing tests (#88) refactor: change verification order at Stream Creation (motivation: previously, passing an endTime < startTime resulted in the CliffTimeNotLessThanEndTime error being returned) chore: update bun dependencies
2 participants
Depends on #87.
refactor: change verification order at Stream Creation (motivation: previously, passing an endTime < startTime resulted in the CliffTimeNotLessThanEndTime error being returned)
chore: update bun dependencies