Conversation
a6344e9 to
ac90c5e
Compare
andreivladbrg
left a comment
There was a problem hiding this comment.
We shouldn't reference a specific Rust toolchain version from the past, as it'll, normally, become incompatible with the rest of the dependencies quite soon - and require regular maintenance.
that's correct only if we update the other dependencies as well, right?
the idea is to have a stable version of deps — so that we won't update them constantly, causing continuous refactors
my motivation for having a fixed version for building the program is to make it pass no matter what someone uses locally — it may be 2025-04-01 or not — but we should aim, IMO, for a stable version
Generally speaking, we should either "pin" all of the tool versions (for Rust, Anchor & Solana) - or none, at all, because, sometimes, they develop independently, leading to incompatibilities between them (this is what happened recently, e.g.). Now, I'm not sure it'd be a good idea to enforce any specific tool version in either the The argument for not enforcing the tool versions in Open for further discussion. |
chore: update Anchor version chore: remove the bytemuck dependency hotfix chore: update other dependencies test: increase CU limit for failing tests (#88) refactor: change verification order at Stream Creation (motivation: previously, passing an endTime < startTime resulted in the CliffTimeNotLessThanEndTime error being returned) chore: update bun dependencies
* feat: RefundableAmountOf Ix * depleted status * refactor: move common view context file to its file * refactor: rename the common context * refactor: rename view context --------- Co-authored-by: Andrei Vlad Birgaoanu <andreivladbrg@gmail.com>
80f2aaa to
48fc56b
Compare
Depends on #86.
chore: remove the bytemuck dependency hotfix
chore: update other dependencies
Note: We shouldn't reference a specific Rust toolchain version from the past, as it'll, normally, become incompatible with the rest of the dependencies quite soon - and require regular maintenance.
Referencing the generic toolchain kind (i.e. nightly or stable) is the way.