Skip to content

Commit

Permalink
test: rename test-regress-nodejsGH-4256
Browse files Browse the repository at this point in the history
Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: nodejs#19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure
  • Loading branch information
ryzokuken committed Mar 8, 2018
1 parent 3dd9688 commit edd6a58
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@

'use strict';
require('../common');

// This test ensures that setting `process.domain` to `null` does not result in
// node crashing with a segfault
// https://github.com/nodejs/node-v0.x-archive/issues/4256

process.domain = null;
setTimeout(function() {
console.log('this console.log statement should not make node crash');
Expand Down

0 comments on commit edd6a58

Please sign in to comment.