Skip to content

Introduce installSecretFn to shorten script when many secrets are used.#228

Closed
catwith1hat wants to merge 1 commit intoryantm:mainfrom
catwith1hat:installSecretFn
Closed

Introduce installSecretFn to shorten script when many secrets are used.#228
catwith1hat wants to merge 1 commit intoryantm:mainfrom
catwith1hat:installSecretFn

Conversation

@catwith1hat
Copy link

@catwith1hat catwith1hat commented Dec 11, 2023

Fixes #227. Tested with 100 secrets.

Please let me know, if you have some feedback on the style. I didn't try too hard, because I don't know what you prefer.

@catwith1hat catwith1hat force-pushed the installSecretFn branch 2 times, most recently from acd9bc6 to 01cd0f1 Compare December 11, 2023 17:43
@tomeon
Copy link

tomeon commented Dec 16, 2023

@catwith1hat -- thanks for tackling this. I too am hitting the "Argument list too long" error. Wanted to draw your attention to NixOS/nixpkgs#274765, where I am attempting to solve this problem for any and all activation scripts.

Copy link
Owner

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this. I have one readability concern, then we can merge.

@catwith1hat catwith1hat force-pushed the installSecretFn branch 2 times, most recently from b3ee74a to 75a1aa6 Compare December 23, 2023 04:51
@catwith1hat
Copy link
Author

I addressed your comments. Please take another look.

@catwith1hat
Copy link
Author

Sorry, did I break the Darwin integration? It's not obvious from the logs on the CI what is happening there. Initially, I didn't pay much attention to the broken tests as many github projects have occassionally broken CIs. But now I see that my other PR #242 does succeed with Darwin, so I am now doubting my hypothesis. Sadly, I have no Darwin machine to test or debug.

@tfc
Copy link

tfc commented Aug 26, 2025

Hello, what's the status of this PR? @catwith1hat

I can test this on darwin if necessary but i am really interested to get this in.

@catwith1hat
Copy link
Author

@tfc It works for me locally and I've been using it for 1yr+. But it doesn't rebase cleanly, and I don't have time to work on it. Also given that haven't gotten a response for 1yr+ neither here nor the other PR, I assume that Ryan isn't taking patches. Therefore closing.

@catwith1hat
Copy link
Author

If somebody wants to reopen the PR, I am releasing my patch/code/whatever hereby into the public domain, yadayada...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error: executing '/nix/store/.../bin/bash': Argument list too long

4 participants