Introduce installSecretFn to shorten script when many secrets are used.#228
Introduce installSecretFn to shorten script when many secrets are used.#228catwith1hat wants to merge 1 commit intoryantm:mainfrom
Conversation
acd9bc6 to
01cd0f1
Compare
|
@catwith1hat -- thanks for tackling this. I too am hitting the "Argument list too long" error. Wanted to draw your attention to NixOS/nixpkgs#274765, where I am attempting to solve this problem for any and all activation scripts. |
ryantm
left a comment
There was a problem hiding this comment.
Thanks for tackling this. I have one readability concern, then we can merge.
b3ee74a to
75a1aa6
Compare
75a1aa6 to
c71f8f5
Compare
|
I addressed your comments. Please take another look. |
|
Sorry, did I break the Darwin integration? It's not obvious from the logs on the CI what is happening there. Initially, I didn't pay much attention to the broken tests as many github projects have occassionally broken CIs. But now I see that my other PR #242 does succeed with Darwin, so I am now doubting my hypothesis. Sadly, I have no Darwin machine to test or debug. |
|
Hello, what's the status of this PR? @catwith1hat I can test this on darwin if necessary but i am really interested to get this in. |
|
@tfc It works for me locally and I've been using it for 1yr+. But it doesn't rebase cleanly, and I don't have time to work on it. Also given that haven't gotten a response for 1yr+ neither here nor the other PR, I assume that Ryan isn't taking patches. Therefore closing. |
|
If somebody wants to reopen the PR, I am releasing my patch/code/whatever hereby into the public domain, yadayada... |
Fixes #227. Tested with 100 secrets.
Please let me know, if you have some feedback on the style. I didn't try too hard, because I don't know what you prefer.