nixos/top-level: pass activation scripts as files to avoid "Argument list too long" error#274765
Open
tomeon wants to merge 1 commit intoNixOS:masterfrom
Open
nixos/top-level: pass activation scripts as files to avoid "Argument list too long" error#274765tomeon wants to merge 1 commit intoNixOS:masterfrom
tomeon wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: nixos
Contributor
Author
|
Cargo-culting some OfBorg stuff from a recent-ish PR touching the same areas...: @ofborg test switchTest |
ofborg
bot
added
10.rebuild-darwin: 1-10
tomeon
changed the title
wegank
added
the
2.status: stale
tomeon
force-pushed
the
top-level-pass-activation-scripts-as-files
branch
from
ee10094 to
a8dcc50
Compare
stale
bot
removed
the
2.status: stale
tomeon
force-pushed
the
top-level-pass-activation-scripts-as-files
branch
from
a8dcc50 to
c23c43a
Compare
Contributor
Author
wegank
added
the
2.status: merge conflict
to stop Bash from complaining "Argument list too long" due to very large activation scripts.
tomeon
force-pushed
the
top-level-pass-activation-scripts-as-files
branch
from
c23c43a to
0979be5
Compare
ofborg
bot
removed
the
2.status: merge conflict
nixpkgs-ci
bot
added
the
2.status: merge conflict
nixpkgs-ci
bot
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stops Bash from complaining "Argument list too long" due to very large activation scripts. Related: ryantm/agenix#227.
Description of changes
This PR updates the activatable system derivation to pass
activationScriptanddryActivationScriptsvia files rather than via environment variables. Activation scripts are liable to grow large enough to make Bash/Linux complain about illegally large argument lists; see the above-linkedagenixissue for one such example.Incidental change: move the
passAsFiledefinition, previously in the body of thebaseSystemsystem derivation definition, intosystem.systemBuilderArgs, making it possible to extend it with[ "activationScript" "dryActivationScript" ]elsewhere.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.