Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding contributors section to gh-pages for #160 #204

Merged
merged 1 commit into from
Nov 4, 2017
Merged

adding contributors section to gh-pages for #160 #204

merged 1 commit into from
Nov 4, 2017

Conversation

lucasreed
Copy link
Contributor

@lucasreed lucasreed commented Oct 14, 2017

Description

Adding the contributors section to the gh-pages site following the all-contributors specification.

This should close out #160

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

  • Creates contributors section above the release note section. Ordering can be modified if necessary.

How should this be manually tested?

My forked gh-pages generated site

Any background context you can provide?

What are the relevant tickets (if any)?

#160, #202

Screenshots (if appropriate or helpful)

@ryanoasis ryanoasis merged commit 7c803b9 into ryanoasis:gh-pages Nov 4, 2017
@ryanoasis
Copy link
Owner

It's up! NerdFonts.com ❤️

Thanks again @lucasreed . I will have to update the contributors list once I finish merging contributions for v1.2.0 (there were a LOT of PRs)

@ryanoasis ryanoasis added this to the v1.2.0 milestone Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants