Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master branch changes for #160 #202

Merged
merged 1 commit into from
Nov 4, 2017
Merged

master branch changes for #160 #202

merged 1 commit into from
Nov 4, 2017

Conversation

lucasreed
Copy link
Contributor

@lucasreed lucasreed commented Oct 13, 2017

Description

I've added a CONTRIBUTORS.md file that includes a table of all contributors in all-contributors format. It also has a badge indicating the number of contributors. This is only the first part of the changes needed for #160

There is also a .all-contributorsrc file that is used with the all-contributors-cli for easy addition of new contributors.

I think this is a good starting point. I tried to match up everyone's actual contributions to an emoji or multiple emojis. Please change them if they aren't correct! Any fonts added I just lumped in with the "code" emoji.

There will be a part 2 PR for #160 to the gh-pages branch but I have to change the format because jekyll doesn't like the markdown used for the table generated by the all-contributors-cli. I may attempt automating the conversion with a script.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

  • add CONTRIBUTORS.md

How should this be manually tested?

  • Click here to see what it looks like in my fork.

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@ryanoasis
Copy link
Owner

Love this 😍 . I'll get to merging this week

@ryanoasis ryanoasis merged commit 317729c into ryanoasis:master Nov 4, 2017
@ryanoasis ryanoasis added this to the v1.2.0 milestone Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants