Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems with release workflow #1745

Closed
Finii opened this issue Nov 19, 2024 · 0 comments · Fixed by #1758
Closed

Problems with release workflow #1745

Finii opened this issue Nov 19, 2024 · 0 comments · Fixed by #1758
Labels
⚠ bug CI ⚙ Automation and release related

Comments

@Finii
Copy link
Collaborator

Finii commented Nov 19, 2024 •
edited
Loading

  • The patcher uses glyphnames to name the glyphs on patching
  • The release workflow
    • Updates the version strings
    • Patches the fonts
    • Updates the glyphnames file
  • So the glyphname update is too late, if any are changed, i.e. on symbol updates
@Finii Finii added ⚠ bug CI ⚙ Automation and release related labels Nov 19, 2024
Finii added a commit that referenced this issue Nov 26, 2024
@Finii
CI: Regenerate glyphnames before release
34620c5 
[why]
When the icon sets have changed (added or names changed) the i_*.sh
files are (hopefully) up to date, but the glyphnames.json file is only
updated on release.

Unfortunately the font-patcher uses the glyphnames.json to determine the
patched-in glyphs' names, but in the workflow the json file is only
updated after all fonts have been patched.

[how]
Like the version number in the font-patcher file we also create a
transient glyphnames.json in each patching job, that the font-patcher
can then utilize.

Still the in-repo glyphnames.json is only updated after successful
release. So in pinciple we call the generate-css.sh (which also
generates the glyphnames.json) once for every font in the font matrix
(just before patching) and then finally after all patching has been done
again and that is committed back to the repo.

Fixes: #1745

Signed-off-by: Fini Jastrow <[email protected]>
@Finii Finii mentioned this issue Nov 26, 2024
Merged
4 tasks
@Finii Finii closed this as completed in 7b23967 Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚠ bug CI ⚙ Automation and release related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix glyphnames in released fonts ryanoasis/nerd-fonts
1 participant
@Finii