Skip to content

Commit

Permalink
CI: Regenerate glyphnames before release
Browse files Browse the repository at this point in the history
[why]
When the icon sets have changed (added or names changed) the i_*.sh
files are (hopefully) up to date, but the glyphnames.json file is only
updated on release.

Unfortunately the font-patcher uses the glyphnames.json to determine the
patched-in glyphs' names, but in the workflow the json file is only
updated after all fonts have been patched.

[how]
Like the version number in the font-patcher file we also create a
transient glyphnames.json in each patching job, that the font-patcher
can then utilize.

Still the in-repo glyphnames.json is only updated after successful
release. So in pinciple we call the generate-css.sh (which also
generates the glyphnames.json) once for every font in the font matrix
(just before patching) and then finally after all patching has been done
again and that is committed back to the repo.

Fixes: #1745

Signed-off-by: Fini Jastrow <[email protected]>
  • Loading branch information
Finii committed Nov 26, 2024
1 parent b4d1b5b commit 7b23967
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,13 @@ jobs:
fontforge --version
fontforge --version 2>&1 | grep libfontforge | awk '{print $NF}'
- name: Bump version for source files
- name: Bump version for source files and update glyphnames.json
# and check if generated glyphnames.json is valid
run: |
cd -- "$GITHUB_WORKSPACE/bin/scripts"
./version-bump.sh "$RELEASE_VERSION"
./generate-css.sh
jq . ../../glyphnames.json > /dev/null
- name: Patch all the variations of the font family
run: |
Expand Down

0 comments on commit 7b23967

Please sign in to comment.