Replies: 5 comments 5 replies
-
The first big batch of pulled PRs just went through. Now examining the results
Furthermore: Check if we would benefit from also putting #801 on the list. ✔️ included |
Beta Was this translation helpful? Give feedback.
-
Checklist for release:
🎉 Seems CI is working as expected with
|
Beta Was this translation helpful? Give feedback.
-
This PRs release process had to possible problematic behavior to publish the release immediately, i.e. when the first release pack (font) is uploaded. Other fonts will be uploaded one by one later on. People or scripts that check for a new release regularly can be presented with an incomplete release. The 2.2.0 release had a severe bug anyhow (#895), and in the process of fixing it also the release process has been changed (75ce899). Now the release is created as draft. The drawback is that I could not figure out (fast enough) how to un-draft the release. I tried to write to the same release without the draft flag, but that created another same-named but distinct release. This needs still some work. And then, scoop buckets are automatically updated every hour via cron (https://github.com/matthewjberger/scoop-nerd-fonts), but not mentioned as install method. Not that I have ever used Scoop. Might be a good addition to the docs. |
Beta Was this translation helpful? Give feedback.
-
After a lot of thinking and seeing issues, I believe the commit reverted with #764 is indeed a regression of #270. Some backlinks
This is a important enough issue to come up with another bugfix release. I guess. |
Beta Was this translation helpful? Give feedback.
-
Hey @Finii thank you so much for carrying on. Please forgive my lack of input and involvement of late. Awesome job on the releases, really appreciate the work and glad things got moving again. I think you made the best decisions you could give complete lack of direction on my part 😢 . It's bittersweet to see the project flourish without me. I think I just needed a break and it was one of those cases where I had been away so long I wasn't sure how to jump back in and well it's a bit awkward now but oh well 😊 I'm trying to get back up to speed but there have been quite a lot of changes (which is good for progress bad for me catch up 😆 ) With that said if there is anything in particular you want my input on please ping it here, otherwise i'll continue to review the releases, discussions, issues, etc. so I can start getting back to helping out here. 🤞🏻 |
Beta Was this translation helpful? Give feedback.
-
I tried to identify stuff that should be pulled for 2.2.0 and set the milestones:
https://github.com/ryanoasis/nerd-fonts/pulls?q=+is%3Apr+milestone%3Av2.2.0+
These affect only known bugs in the patched/released fonts and no release-fonts unrelated bugfixes, convenience or feature items.
There are also no 'political' or 'controversial' PRs.
I will try to pull now all these PRs, check the gerenated font set and if all goes well trigger the release. A lot of people struggle with the bugs in 2.1.0 and rely on 'real release' for one reason or another (i.e. because of AUR).
I was very hesitant to pull any PRs, but @ryanoasis is now absent a rather long time and I try to keep to his intentions as good as I can.
Please Ryan, if you do not like that, just tell me and I will stop. But I believe this is in the interest of Nerd Fonts.
Beta Was this translation helpful? Give feedback.
All reactions