Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts from 2.0 release are not being correctly identified as Monospace #270

Closed
notrev opened this issue May 23, 2018 · 48 comments
Closed

Fonts from 2.0 release are not being correctly identified as Monospace #270

notrev opened this issue May 23, 2018 · 48 comments
Labels
Milestone

Comments

@notrev
Copy link

notrev commented May 23, 2018

🎯 Subject of the issue

Initial issue description (from 23/May/2018)
I use Meslo LG M for Powerline and want to use the Nerd Fonts patched version. I tried all Meslo LG M in the repository, but none of them appeared in the gnome-terminal's fonts list. they were listed in the system, thought (in the fonts application).

I also downloaded the original ones, without any patches, and they got listed.

Anyone has any clue about how to fix this?

Update 24/May/2018
I have also tried Droid Sans, and it is not being listed too.
I downloaded Terminator to see if it lists them, and it did.

Update 31/May/2018
With other people experiencing the same issue with other fonts, the issue's title was updated from "Meslo fonts not being listed on gnome-terminal" to the current one, as suggested by @Gargoyle.

🔧 Your Setup

  • Meslo LG M forPowerline, trying to change to Meslo LG M Nerd Fonts
  • Gnome terminal
  • Ubuntu 18.04
@paul-court
Copy link

I have the same with the three I have tried so far:- Hack, Anonymous Pro and Bitstream Vera.

I've installed "Font Manager" which has a bit more functionality than the standard Gnome "Fonts" app, and it it showing all three of these as having proportional spacing - which is why Gnome Terminal will not list them.

I downloaded the files from the release archive (https://github.com/ryanoasis/nerd-fonts/releases/tag/v2.0.0) as per the instructions.

@joke2k
Copy link

joke2k commented May 27, 2018

I tried with Fura, and I found the same issue.
The gnome terminal ignore fonts with "proportional spacing".
the font became proportional after the patch?

@matjam
Copy link

matjam commented May 27, 2018

So, try this

sudo rm /etc/fonts/conf.d/70-no-bitmaps.conf

I know its not a bitmap font but I have had more luck since I did that.

@joke2k
Copy link

joke2k commented May 29, 2018

Could be works, but I don't like this solution.
This package says:

Monospaced (fixed-pitch, fixed-width) or double-width (non-monospaced) glyphs version of each font

And it would be awesome to have them works without this fix

@notrev
Copy link
Author

notrev commented May 30, 2018

@matjam, I tried your solution, but it did not work or me. It listed a lot of new fonts, but not Meslo LG M, which is the one I want

@paul-court
Copy link

paul-court commented May 30, 2018

Workaround = Goto Releases, Click Tags, Select 1.2, Download.
(https://github.com/ryanoasis/nerd-fonts/releases/tag/v1.2.0)

@joke2k
Copy link

joke2k commented May 30, 2018

@Gargoyle it seems to work, with Fira font at least.
Is there a bug with 2.0?

@paul-court
Copy link

Yes. Something has gone wrong with the build process for 2.0 and none of the fonts (None of the 6-8 that I have tried, anyway) have the correct "spacing" parameter, so they are not being recognised as monospaced fonts when they are installed.

The 1.2 ones all seem fine.

@notrev
Copy link
Author

notrev commented May 31, 2018

The workaround proposed by @Gargoyle works, but the glyphs are small. I read that this is known and there is not much to be done because of the mono font type.

My way of solving this was to change from gnome-terminal to ROXterm, as it is very much like gnome-terminal and accepts the non-mono version of the Meslo font.

Should I close this issue, or should I leave it open, as the issue still persists for gnome-terminal?

@paul-court
Copy link

My gut feeling is that it would be @ryanoasis decision to close or not.

However, you might want to re-name the title since it's not only an issue with gnome-terminal. The 2.0 versions will not show anywhere when you are searching for Monospaced fonts.

Title suggestion: "Fonts from 2.0 release are not being correctly identified as Monospace"

@notrev notrev changed the title Meslo fonts not being listed on gnome-terminal Fonts from 2.0 release are not being correctly identified as Monospace May 31, 2018
@ryanoasis ryanoasis added this to the v2.1.0 milestone Jun 1, 2018
@ryanoasis
Copy link
Owner

Hey thanks everyone this is definitely a big issue that I have been following along with quietly. I won't be able to contribute too much to this project for the next several months but if I get some time and there are quick wins or PRs I will do my best 😄

@xasx
Copy link

xasx commented Jun 4, 2018

They do not appear in the selection box, however, with any gconf editor one can set the font of the respective profile manually.

I used dconf-editor and modified the value in the respective profile found beneath org/gnome/terminal/legacy/profiles:

@paul-court
Copy link

I'm not sure I would recommend that, @xasx. The developers of gnome-terminal have deliberately put measures in place to make sure only monospaced fonts are used.

If you use a gconf editor to "get round" that limitation, then you are opening yourself up to possible problems/issues which the developers have tried to avoid or would not expect to happen.

@brennanfee
Copy link
Contributor

@Gargoyle Nice title change suggestion.

Also, your solution for Gnome terminal is great but does mean that people miss out on a lot of the improvements made in 2.0 like the addition of the Material Icons and other updates. If there is an issue with the builds in 2.0 we should probably keep this issue focused on that which, sounds like, fixes multiple problems.

@xasx
Copy link

xasx commented Jun 4, 2018

@Gargoyle I'd not generally recommend this. However, it is a way I found to make something work that should be actually working - that said, keep in mind that the bug is actually on NerdFonts side making it impossible for gnome-terminal to correctly detect it as being monospaced (or usable, whatever counts).

@westernmagic
Copy link

Reverting 31d7524 and recompiling fonts seems to solve the issue (with Fura Code and Qterminal).

@philFernandez
Copy link

I downloaded Terminator, which I believe is a fork of Gnome Terminal, and nerd fonts show up and work perfectly there. The functionality and settings options of Terminator and Gnome Terminal are very similar.

@phcerdan
Copy link

phcerdan commented Jul 7, 2018

Hitting this from aur package in ArchLinux https://aur.archlinux.org/packages/nerd-fonts-complete/ , which uses latest release. Gnome terminal does not recognize most of the fonts as monospace, so they are not showing up.

@haasosaurus
Copy link
Contributor

haasosaurus commented Jul 14, 2018

i fixed this in my fork, i did a pull request. i'm new at this, sorry.

#283

@zfil
Copy link

zfil commented Jul 14, 2018

@haasosaurus you need to do a pull request on this project not on your fork.

@haasosaurus
Copy link
Contributor

@zfil thank you, i fixed it

@haasosaurus
Copy link
Contributor

you can use the fonts in this branch of my fork for the time being, let me know if they work if you try them please. https://github.com/haasosaurus/nerd-fonts/tree/regen-mono-font-fix

@MatthewCushing
Copy link

There's a way to get around this with everything working for the Gnome-Terminal. Start up "dconf-editor" in the terminal. Then go to org>gnome>terminal>legacy>profiles:>profile id>font and change the custom value to the font you wish to use. So far the Meslo LGL font you would put in MesloLGL Nerd Font Regular 12
12 being the font size.

@paul-court
Copy link

@mrcush Already mentioned above why that might not be a good idea.

If you mess with dconf-editor manually, you could get the application into states the developers didn't anticipate.

@paul-court
Copy link

@mrcush / @gymgle, yes dconf-editor can be used for a work around and in this instance the risk is probably limited to character spacing issues.

However, it shouldn't become habit to use such a tool without due consideration. Today it's just a font issue, tomorrow it could be something a bit more critical.

As an example, make a mental node of this little gem which seems to becoming an increasingly popular way to tell users to install some bit of software:-

wget https://my.web.address/projectx/installer.sh | sudo bash

Yes, it's a one liner that any fool can copy and paste. But it doesn't stop it being dumb.

durandj added a commit to durandj/dotfiles that referenced this issue Feb 2, 2019
The font setup is still problematic because of this bug in NerdFonts.
ryanoasis/nerd-fonts#270
@villasenor
Copy link

The fork that @haasosaurus has worked immediately for me with a Gnome 3 Terminal / Ubuntu 18.04 setup. Are we waiting for a PR at this point @brennanfee?

@ryanoasis
Copy link
Owner

Thanks all. Getting back up to speed on things

@mg979
Copy link

mg979 commented Feb 17, 2019

All ttf fonts from 2.0.0 are broken in Windows (they don't show up with :set guifont=*). otf fonts work.

@brennanfee
Copy link
Contributor

@villasenor I don't have a pending PR for this. However, I can report that I have verified the fork and patch that @haasosaurus created and the fonts work on windows for the console and various editors. @mg979 I was also able to verify that the fonts show up in gVim (on windows) when using :set guifont=*

@ryanoasis
Copy link
Owner

Thanks @brennanfee and @mg979

@mafuba
Copy link

mafuba commented Apr 20, 2019

Any update here? Really looking forward to this fix.

@Jaykul
Copy link

Jaykul commented May 7, 2019

Anything we can do to get this released? Could be lots of interest in NerdFonts after the demos of the new Windows Terminal at \Build\ conf this week 😉

@ryanoasis
Copy link
Owner

The only thing blocking is me (#283 (comment)) testing out the #283 PR specifically the possible issue that #283 (comment) brings up. If someone else wanted to test out the issue brought up and either fix it or be unable to replicate then I'd be inclined to merge.

Perhaps we could even just merge knowing the side effect. I am torn.

I won't be able to do much on the project until June unfortunately. Thanks for the patience

@Jaykul
Copy link

Jaykul commented May 11, 2019

The actual built fonts in from regen-mono-font-fix/patched-fonts seem to have some issues with ligatures. I'm getting this:
image

@krokofant
Copy link

@ryanoasis Merge it, seems weird to wait so long to fix something that is broken. If it introduces another bug then let's have at it.

@BlueDrink9
Copy link

It does seem like this is preventing many programs from recognising the fonts as usable, which affects a lot of people hugely. The blocking bug only affects those that use ligatures/diacritics, and even then they can still use the rest of the font.
Utilitarianism suggests merge

@ryanoasis
Copy link
Owner

#283 has been merged, sorry for the wait. Let's move forward 😄

@damnskippy
Copy link

@ryanoasis is there a way to download patched fonts with this fix? Thank you.

@ryanoasis
Copy link
Owner

@damnskippy Not at the moment. We need to run the rebuild script to re-patch all the fonts (takes a few hours). This isn't an issue but I'd like to batch several source font changes in too (since we are rebuilding anyway to avoid having to rebuild the source fonts for each change). E.g. #289 will likely be done before re-patching everything. Thanks

@errantepiphany
Copy link

errantepiphany commented Jul 7, 2019

Hi @ryanoasis . I'm sorry to bug you, as I'm sure you're very busy. But may I please ask when you might be able to run the rebuild script to re-patch all the fonts, now that #283 has been merged? Even if the fix for #289 is not ready yet, I think getting re-patched fonts out sooner will help a lot of people. Thank you very much - we appreciate it!

@ryanoasis
Copy link
Owner

ryanoasis commented Aug 16, 2019

@errantepiphany No worries, I am going to try to push out 2.1.0 release this month, so I will be re-patching all the fonts at least once if not multiple times until things appear to be correct. Thanks!


edit
Most of the tasks in 2.1.0 are actually done or just pending rebuild... https://github.com/ryanoasis/nerd-fonts/milestone/19

@errantepiphany
Copy link

@ryanoasis Awesome news - thank you!

@BlueDrink9
Copy link

Hi Ryan, would you mind giving a status update here please?

@ryanoasis
Copy link
Owner

@BlueDrink9 I am updating the changelog for 2.1.0 as I type this

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests