add setup_job_directory shortcut #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critias
requested changes
Sep 1, 2022
There was a problem hiding this comment.
If a job isn't inside the graph this will probably crash since tk.sis_graph.find("%s") returns an empty array. Given that you check each config file individually it will not work if the first config file doesn't contain the job.
Either pass all config files at once or allow only one config file as input.
| @@ -179,6 +188,12 @@ def remove_job_and_descendants(args): | |||
| call_sis(call) | |||
|
|
|||
|
|
|||
| def setup_job_directory(args): | |||
| for conf_file in args.argv: | |||
There was a problem hiding this comment.
Does passing all config files at once cause problems?
|
I don't mind having this shortcut. @JackTemaki is this still relevant for you? |
Well, this is just a small convenience increase that you do not have to open the console for that, I would not call it relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.