Custom cursor improvements#3292
Merged
daxpedda merged 3 commits intorust-windowing:masterfrom Dec 23, 2023
Merged
Conversation
daxpedda
requested review from
jackpot51,
kchibisov,
madsmtm and
msiglreith
as code owners
madsmtm
reviewed
Dec 23, 2023
Member
madsmtm
left a comment
madsmtm
left a comment
There was a problem hiding this comment.
Move
ArcinCustomCursorto platform implementations
Thanks, I thought about that too!
madsmtm
approved these changes
Dec 23, 2023
daxpedda
force-pushed
the
custom-cursor-improvements
branch
from
d4343ee to
e1bbd2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlatformCustomCursorBuilder::build()toPlatformCustomCursorso platforms can implement their own caching if they want to. See MacOS: cache custom cursor #3291.ArcinCustomCursorto platform implementations so platforms who have their own reference counting can use that. E.g. MacOS withId.No public API or backend changes.