Skip to content

MacOS: cache custom cursor#3291

Merged
daxpedda merged 1 commit intorust-windowing:masterfrom
daxpedda:macos-cache-custom-cursor
Dec 23, 2023
Merged

MacOS: cache custom cursor#3291
daxpedda merged 1 commit intorust-windowing:masterfrom
daxpedda:macos-cache-custom-cursor

Conversation

@daxpedda
Copy link
Member

This moves the creation of NSCursor to CustomCursorBuilder::build().

Note: no public API changes.

@daxpedda daxpedda added the DS - appkit Affects the AppKit/macOS backend label Dec 23, 2023
@daxpedda daxpedda requested a review from madsmtm as a code owner December 23, 2023 11:57
@daxpedda daxpedda force-pushed the macos-cache-custom-cursor branch 2 times, most recently from 3c070e5 to 5250e73 Compare December 23, 2023 12:08
@daxpedda daxpedda marked this pull request as draft December 23, 2023 13:46
@daxpedda daxpedda force-pushed the macos-cache-custom-cursor branch from 5250e73 to 4b533c9 Compare December 23, 2023 13:52
@daxpedda
Copy link
Member Author

Gonna wait for #3292 first.

@daxpedda daxpedda force-pushed the macos-cache-custom-cursor branch from 4b533c9 to f8ebf32 Compare December 23, 2023 15:13
@daxpedda daxpedda marked this pull request as ready for review December 23, 2023 15:13
@daxpedda daxpedda requested a review from madsmtm December 23, 2023 15:13
@daxpedda daxpedda force-pushed the macos-cache-custom-cursor branch from f8ebf32 to dadf9f4 Compare December 23, 2023 15:23
@daxpedda daxpedda force-pushed the macos-cache-custom-cursor branch from dadf9f4 to 3d6ab93 Compare December 23, 2023 15:25
Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daxpedda daxpedda merged commit a8f49dc into rust-windowing:master Dec 23, 2023
@daxpedda daxpedda mentioned this pull request Dec 24, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DS - appkit Affects the AppKit/macOS backend

Development

Successfully merging this pull request may close these issues.

2 participants