A way to disable key repeats

[ryanisaacg]

At least on Windows, key events seem to respond with a delay (especially when a key is being mashed) due to key repeat handling. Is there any way to disable this?

(Originally I asked in glutin but was referred here)

[elinorbgr]

For the record, the usecase of disabling key repeats is also of interest for smithay, otherwise we would need to filter-out repeated events...

[ryanisaacg]

@vberger I think you're missing the ":" in the "https://" of your link

[elinorbgr]

Indeed, I've corrected it. 😅

[francesca64]

We actually can't implement this on X11 without resorting to heuristics, though AFAIK it's straightforward to implement on Windows.

[francesca64]

It's also easy to implement on macOS. Since there's a precedent for how to handle this on X11, we might as well go for it (though I don't consider it a priority at present).

What's the ideal here? Adding an is_repeat field to KeyboardInput? Or it being configurable to completely strip out repeats? Both?

[fschutt]

On windows, key repetition is currently way too fast, I'm not sure what's up with that, if it's a bug or not - is there any way to disable key repetition in winit? It's just because if I type "Hello World", I get "HHeeello WWWorrrrld" because the delay for key repetition is extremely low for some reason.

[francesca64]

@fschutt I'm not able to reproduce that on Windows 10, though making it possible to filter key repeats would be easy on all platforms other than X11. I'm curious about why that's happening at all, though.

[ghost]

I'd suggest (without knowing the internals of winit) to add a new ElementState: Repeat.
It can be discarded in the event loop if required.

[Osspial]

Closing in favor of #753 and #812

[ktnlvr]

It seems like necroposting, but I've spend a decent amount researching relevant issues with no avail. Perhaps a hacky solution could be outlined at least as a temporary fix? It seems like the proposed bodge solution from GLFW doesn't exactly work, since winit doesn't provide the event timestamps.

[kchibisov]

KeyEvent has is_repeat field, so simply ignore repeats.

[ktnlvr]

Am I missing any feature flags? Currently looking at the latest 0.28.6 version and not seeing anything called KeyEvent or similar. There is KeyboardInput, but it doesn't seem to have the is_repeat field.

[kchibisov]

Yeah, you need winit from master.