Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter repeat key presses dont work for some letters in some sequences in the editor #368

Closed
Chadtech opened this issue May 30, 2020 · 5 comments
Labels
bug Something isn't working editor The Roc editor

Comments

@Chadtech
Copy link
Contributor

Chadtech commented May 30, 2020

You know how if you press and hold the g key youll get gggggggggg (in some editors)?

That works, but if I do several back to back, immediately switching from one letter to the next, some letters dont work.

Here is a screen shot. All letter presses were pressed and held, not simply pecked.
Screen Shot 2020-05-30 at 15 59 28

So, If I pressed and held c, f, and g for example, immediately back to back, I only got "ccccccccccfg".

I tried these examples on both my external keyboard and the keyboard built into my mac to test out whether it was my hardware. Different keyboard hardware did not lead to a different result.

@rtfeldman
Copy link
Sponsor Contributor

I can't reproduce this anymore on macOS since #388 was merged - @Chadtech can you still reproduce this on current trunk?

@rtfeldman rtfeldman added the bug Something isn't working label Sep 4, 2020
@Chadtech
Copy link
Contributor Author

Chadtech commented Sep 4, 2020

It seems to be mostly gone? I can reproduce the problem with only the key sequence ccccccccfg. But it looks like I had problems with kkkkop and nnnnjk before, and I dont have problems with those combinations at all now.

Screen Shot 2020-09-04 at 00 08 08

@Chadtech
Copy link
Contributor Author

Chadtech commented Sep 4, 2020

I tried to see if I could reproduce this in a different text editor and in my terminal I can do cccccfffffgggggg. Besides my terminal I couldnt find an editor that has this key repeat functionality. Not Zulip, mac notes, google drive, intellij, or this text area.

Maybe its not an issue because editors just dont do this key repeat thing anyway?

@rtfeldman
Copy link
Sponsor Contributor

rtfeldman commented Sep 4, 2020

Ah, okay - it looks like this is an upstream issue in winit. (Also rust-windowing/winit#734)

I think it's fine to wait for an upstream solution on this one. 😄

@rtfeldman rtfeldman added the editor The Roc editor label Jun 22, 2022
@JanCVanB
Copy link
Sponsor Collaborator

JanCVanB commented Sep 9, 2022

I can't reproduce this in the Roc editor (on Linux), but perhaps I'm doing it wrong. @Chadtech @rtfeldman and others, please feel free to reopen this issue for any reason!

@JanCVanB JanCVanB closed this as completed Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working editor The Roc editor
Projects
None yet
Development

No branches or pull requests

3 participants