Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child window without decorations not working on Win 10 #2754

Closed
siriux opened this issue Apr 2, 2023 · 1 comment · Fixed by #3410
Closed

Child window without decorations not working on Win 10 #2754

siriux opened this issue Apr 2, 2023 · 1 comment · Fixed by #3410
Labels
B - bug Dang, that shouldn't have happened DS - windows

Comments

@siriux
Copy link

siriux commented Apr 2, 2023

Setting decorations to false doesn't work on child windows on Win 10, the decorations are still visible.

This might be related to other decoration issues that appeared after #2419

I don't have much experience with the winit code base, but as far as I can see WS_CAPTION and WS_BORDER are always added to the window style and never removed (except in adjust_rect(...) that is not initially called).

Maybe they can only be added if decorations are activated in the first place?

Thanks

@msiglreith msiglreith added B - bug Dang, that shouldn't have happened DS - windows labels Apr 6, 2023
@msiglreith
Copy link
Member

Thanks for the report, right these window styles should probably be excluded as the are only needed for system native behavior of the top level windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B - bug Dang, that shouldn't have happened DS - windows
2 participants