Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rand::distributions -> distr; split uniform module #1470

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Jul 18, 2024

  • Added a CHANGELOG.md entry

Summary

This includes the contents of and will need a rebase after #1469, so the first real commit here is "Cfg-gate whole rand::seq::index module".

Implements #1381.

Motivation

I have long found the uniform.rs module hard to navigate, hence the split there.

Putting the contents in the existing float/int/other modules would need some quirky imports to keep the uniform public module intact (I also considered making this module private and directly re-exporting the contents, but it seems to serve a purpose, especially for documentation and to house the implementing types like UniformInt). Using new uniform/float.rs etc. modules results in a soft name-clash; the included path renames look better in my editor at least, but I can go the more orthodox approach if preferred.

@dhardy dhardy requested a review from newpavlov July 18, 2024 09:54
@dhardy dhardy force-pushed the reorg branch 2 times, most recently from 8f38384 to b1240aa Compare July 19, 2024 13:36
@dhardy dhardy marked this pull request as ready for review July 23, 2024 13:00
@dhardy dhardy merged commit 2d5948d into rust-random:master Jul 23, 2024
15 checks passed
@dhardy dhardy deleted the reorg branch July 23, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants