Portability fixes #1469
Merged
Portability fixes #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also assert that pointer width is an expected value.
1 task
newpavlov
reviewed
Jul 18, 2024
| @@ -10,10 +10,10 @@ | |||
|
|
|||
| use rand_core::{RngCore, SeedableRng}; | |||
|
|
|||
| #[cfg(any(target_pointer_width = "32", target_pointer_width = "16"))] | |||
There was a problem hiding this comment.
Why change it from not(target_pointer_width = "64")? Even with hypothetical 128-bit targets it's better to use Xoshiro128++ than to break builds. Alternatively, it's worth to at least add a compile_error! stating that we support only 16, 32, and 64 bit targets.
There was a problem hiding this comment.
- Because this is explicit about what is supported and recommended
- Effectively it is a compile error
- I don't care about theoretical targets. If people want to target 16- or 128-bits on rand, they can submit patches.
src/distributions/slice.rs
Outdated
| #[cfg(feature = "alloc")] | ||
| use alloc::string::String; | ||
|
|
||
| #[cfg(not(any(target_pointer_width = "32", target_pointer_width = "64")))] | ||
| const _: () = assert!(false, "unsupported pointer width"); |
There was a problem hiding this comment.
Why not use compile_error! here? Also, why can't we use UniformSize::U32 on 16-bit targets?
There was a problem hiding this comment.
- I forgot about it — I'll switch to
compile_error! - Dependencies don't compile and it seems like no-one cares much about 16-bit (Supported target_pointer_width: 32, 64-bit only? #1468), so there's no point wasting time here.
dhardy
commented
Jul 19, 2024
Comment on lines
+20
to
+24
| enum UniformUsize { | ||
| U32(Uniform<u32>), | ||
| #[cfg(target_pointer_width = "64")] | ||
| U64(Uniform<u64>), | ||
| } |
There was a problem hiding this comment.
As with gen_index, this should probably be exposed somehow (left for a future PR).
newpavlov
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Fixes some of the smaller issues noted here. Specifically:
choose_multiple_arrayrand::distributions::SliceFurther, this makes it more explicit which
target_pointer_widthsizesSmallRngbackends are intended to support (the 16-bit choice is not intended to be optimal).