Fix default feature breakage #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change (rust-osdev@1d3a8af) made it so some previous code using `SerialPort::new()` wouldn't compile if the user was using the default feature set. Fixing this to just be `default = [ "nightly" ]` sets the same features for `x86_64`, while preventing breakage. See: cloud-hypervisor/rust-hypervisor-firmware#66 Signed-off-by: Joe Richey <[email protected]>
|
Thanks a lot, and sorry for the breakage! |
phil-opp
added a commit
that referenced
this pull request
Oct 1, 2020
|
Published as v0.2.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change (1d3a8af) made it so some previous code using
SerialPort::new()wouldn't compile if the user was using the default feature set.Fixing this to just be
default = [ "nightly" ]sets the same features forx86_64, while preventing breakage.See: cloud-hypervisor/rust-hypervisor-firmware#66
Signed-off-by: Joe Richey [email protected]