Update Rust toolchain to nightly-2020-10-01 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akira Moroo <[email protected]>
retrage
force-pushed
the
nightly-2020-10-01
branch
from
6c2a038 to
d0e32d6
Compare
|
I'd like to avoid depending on lazy_statoc if possible. I think we can fix this without using an external crate, I'll take a look |
Closed
josephlr
added a commit
to josephlr/uart_16550
that referenced
this pull request
Oct 1, 2020
A recent change (rust-osdev@1d3a8af) made it so some previous code using `SerialPort::new()` wouldn't compile if the user was using the default feature set. Fixing this to just be `default = [ "nightly" ]` sets the same features for `x86_64`, while preventing breakage. See: cloud-hypervisor/rust-hypervisor-firmware#66 Signed-off-by: Joe Richey <[email protected]>
josephlr
force-pushed
the
nightly-2020-10-01
branch
2 times, most recently
from
b746e97 to
7464777
Compare
|
Also, thanks @retrage for fixing this!! I updated this PR to set the correct features on the |
josephlr
approved these changes
Oct 1, 2020
The recent version of Rust cannot build x86_64 crate v0.11 because it does not allow function pointers in constant functions[1]. This commit updates the version to fix the build error. [1] rust-lang/rust#57563 Signed-off-by: Akira Moroo <[email protected]> Signed-off-by: Joe Richey <[email protected]>
This is Cargo.lock updates regarding previous two commits. Signed-off-by: Akira Moroo <[email protected]> Signed-off-by: Joe Richey <[email protected]>
The newer version of Rust (after 2020-07-30) requires the latest cargo-xbuild v0.6.2[1]. [1] rust-osdev/cargo-xbuild@400592f Signed-off-by: Akira Moroo <[email protected]>
CONST_ITEM_MUTATION list[1] warns mutable copy of STDIN and STDOUT when creating UEFI SystemTable. This commit fixes these warnings. [1] rust-lang/rust#75573 Signed-off-by: Akira Moroo <[email protected]> Signed-off-by: Joe Richey <[email protected]>
Clippy suggests that using strip_prefix over str::starts_with and slicing[1]. [1] https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip Signed-off-by: Akira Moroo <[email protected]>
josephlr
force-pushed
the
nightly-2020-10-01
branch
from
7464777 to
d62b2f8
Compare
This was referenced Oct 2, 2020
|
Nice! Thanks. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Rust toolchain to the latest (nightly-2020-10-01).
There are a few changes to get work:
It does not allow function pointers in constant functions
It does not allow runtime calls in statics.