Add r? me as an alias for self-assignment
#2218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
approved these changes
Oct 29, 2025
|
|
||
| // Allow `me` as an alias for self-assign, which is always allowed. | ||
| if let [name] = names | ||
| && name == "me" |
There was a problem hiding this comment.
It's a bit disqualifying for https://github.com/me.. 😆 But until they become a Rust team member, I guess it's fine.
There was a problem hiding this comment.
That's unexpected. 😄
If they ever become part of the project we could make it so r? @me does assign them.
There was a problem hiding this comment.
That already applies to users called like adhoc groups like compiler (https://github.com/compiler) :D (or user try (https://github.com/try) in the case of bors (@bors2 delegate=try))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested at #t-compiler/contrib-private > Encouraing more compiler reviewer on rotation? @ 💬