Skip to content

Add r? me as an alias for self-assignment #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

Add r? me as an alias for self-assignment #2218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/handlers/assign.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,6 +803,13 @@ async fn find_reviewer_from_names(
return Ok(ReviewerSelection::from_name(name.clone()));
}

// Allow `me` as an alias for self-assign, which is always allowed.
if let [name] = names
&& name == "me"
Copy link
Member

@Kobzol Kobzol Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit disqualifying for https://github.com/me.. 😆 But until they become a Rust team member, I guess it's fine.

Copy link
Member Author

@Urgau Urgau Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's unexpected. 😄

If they ever become part of the project we could make it so r? @me does assign them.

Copy link
Member

@fmease fmease Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That already applies to users called like adhoc groups like compiler (https://github.com/compiler) :D (or user try (https://github.com/try) in the case of bors (@bors2 delegate=try))

{
return Ok(ReviewerSelection::from_name(requested_by.to_string()));
}

let candidates =
candidate_reviewers_from_names(db, workqueue, teams, config, issue, names).await?;
assert!(!candidates.is_empty());
Expand Down
Loading