Skip to content

Fix self-assign fast path #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

Fix self-assign fast path #2060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/handlers/assign.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,7 @@ async fn determine_assignee(
&teams,
config,
&event.issue,
&event.issue.user.login,
&[name],
)
.await
Expand All @@ -420,6 +421,7 @@ async fn determine_assignee(
&teams,
config,
&event.issue,
&event.issue.user.login,
&candidates,
)
.await
Expand Down Expand Up @@ -461,6 +463,7 @@ async fn determine_assignee(
&teams,
config,
&event.issue,
&event.issue.user.login,
fallback,
)
.await
Expand Down Expand Up @@ -645,6 +648,7 @@ pub(super) async fn handle_command(
&teams,
config,
issue,
&event.user().login,
&[assignee.to_string()],
)
.await
Expand Down Expand Up @@ -871,11 +875,12 @@ async fn find_reviewer_from_names(
teams: &Teams,
config: &AssignConfig,
issue: &Issue,
requested_by: &str,
names: &[String],
) -> Result<ReviewerSelection, FindReviewerError> {
// Fast path for self-assign, which is always allowed.
if let [name] = names {
if is_self_assign(&name, &issue.user.login) {
if is_self_assign(&name, requested_by) {
return Ok(ReviewerSelection::from_name(name.clone()));
}
}
Expand Down
Loading