Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Jun 6, 2025

We were checking the author of the PR, rather than the author of the comment.

Fixes: #2058

We were checking the author of the PR, rather than the author of the comment.
@Kobzol Kobzol requested a review from jieyouxu June 6, 2025 12:18
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I don't work on the triagebot codebase tho 😄

@jieyouxu
Copy link
Member

jieyouxu commented Jun 6, 2025

r? triagebot

@Urgau
Copy link
Member

Urgau commented Jun 6, 2025

Shouln't we always use event.user()?

@Kobzol
Copy link
Member Author

Kobzol commented Jun 6, 2025

It should be the same, because the determine_assignee is only called on PR being opened or converted from draft. It seemed more explicit like this, because event.user().login always confuses me a bit. But if you prefer the user() function, I'll switch it.

@Urgau
Copy link
Member

Urgau commented Jun 6, 2025

I don't have a preference. Let's merge as is.

@Urgau Urgau added this pull request to the merge queue Jun 6, 2025
Merged via the queue into rust-lang:master with commit 1fb66e7 Jun 6, 2025
3 checks passed
@Kobzol Kobzol deleted the autoassign-special-case branch June 6, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edge case: suppress off-rotation or exceeds-capacity message when self-r??

4 participants