Improve handling of --default-host #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we wouldn't honour `--default-host` if we specified `--default-toolchain none` or if there was an existing installation we were updating. This should reduce surprise a little. Fixes: rust-lang#2082 Signed-off-by: Daniel Silverstone <[email protected]>
In order to reduce surprise, if the user did not explicitly supply or explicitly set a default host triple during installation then we do not override whatever the configuration picks by default from the host/build. Signed-off-by: Daniel Silverstone <[email protected]>
kinnison
force-pushed
the
kinnison/fix-default-host
branch
from
6a92580
to
5fd873a
Compare
|
@faern do you think this will solve your problem, the behaviour is now approximately: If user specifies |
|
Great. Yes I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously having somewhat surprising behaviour for
--default-hostwhen combined with--default-toolchain noneor an installation where there already is a default toolchain. This PR corrects that hopefully, making the use of those arguments less surprising.