Some small improvements

[KlossPeter]

Mostly clippy suggestions, some might improve perf (as removing unneeded clones), most should improve readability.

[tesuji]

You need to run cargo fmt on finish.

[kinnison]

These look pretty good, but I don't like a commit labelled rustfmt in the middle. Could you please rebase, folding the formatting into the commits which need them? Once that's done, I think this can be merged. 👍

[bors]

☔ The latest upstream changes (presumably #2086) made this pull request unmergeable. Please resolve the merge conflicts.

[kinnison]

Hi @KlossPeter

Your branch needs rebasing onto current master as there are conflicts which need resolving. In addition, could you please remove the formatting patch and instead ensure on each commit that cargo fmt has already been run?

You may find it easier to complete the rebase if you make many smaller commits.

Thanks,

Daniel.

[kinnison]

Hi @KlossPeter

Have you run out of time to work on this, or decided to go and do something else? It's no problem if you have, but if so, could you please close this PR? If instead you want to fix the conflicts and clean up the commit history then I'd be pleased to look again at it.

[kinnison]

I'm having to assume this has been abandoned.