Add field-access-same-line config option #4889
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3641.
Adds a new configuration option
field-access-same-line
, which puts subsequent field accesses in chains on the same line. For example:turns into
A more elaborate test case is in the tests directory.
Field accesses with indexing (e.g.
self.field[5].field
) in them are not correctly put on a single line, because, apparently, rustfmt splits chains into multiple separateChain
objects when there is indexing in it. I don't know the motivation behind this and I think it's too complicated for me as a newcomer to the codebase to fix.