Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow field access on same line when breaking long chain? #3641

Closed
singpolyma-shopify opened this issue Jun 20, 2019 · 3 comments
Closed

Allow field access on same line when breaking long chain? #3641

singpolyma-shopify opened this issue Jun 20, 2019 · 3 comments

Comments

@singpolyma-shopify
Copy link

rustfmt currently requires:

self.serializer
    .writer
    .write_u32::<LittleEndian>(array_offset)?;

It seems that it would be reasonable to have a setting for:

self.serializer.writer
    .write_u32::<LittleEndian>(array_offset)?;
@scampi
Copy link
Contributor

scampi commented Jun 25, 2019

@topecongiro Do you want to have a new config option for this ? Or an improvement to the default formatting of chains ?

@singpolyma-shopify
Copy link
Author

@scampi either. Having this be the default seems right to me, but if others disagree an option works fine.

@ytmimi
Copy link
Contributor

ytmimi commented Jul 20, 2022

Going to close this in favor of #4306, which has a lot more discussion on chain formatting

@ytmimi ytmimi closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants