Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gdb-cmd for rust-gdbgui #99194

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Fix gdb-cmd for rust-gdbgui #99194

merged 1 commit into from
Oct 9, 2022

Conversation

simlay
Copy link
Contributor

@simlay simlay commented Jul 12, 2022

With cs01/gdbgui#198, the way that gdbgui arguments were specified changed. I've tested this with program generated from cargo new --bin and it worked as gdbgui should.

Closes #76383.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 12, 2022
@Mark-Simulacrum
Copy link
Member

What is the compatibility story with older gdbgui here? Should we try both versions somehow (catching errors?)?

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2022
@simlay
Copy link
Contributor Author

simlay commented Jul 18, 2022

What is the compatibility story with older gdbgui here? Should we try both versions somehow (catching errors?)?

Looks like 0.13.0 was when the breakage happened which was released July 16th 2018.

I couldn't find a great graph tool of gdbgui downloads by package version. I did find pepy.tech but don't know how reliable it is. Based on looking at recent downloads of the gdbgui 0.13.2 compared to 0.12.0.0, it seems that pre-0.13 gdbgui isn't downloaded (and so I assume used) much at all. Though, the numbers by week vs the total columns have unclear meaning. Maybe "total" means "total downloads for all packages".

Anyway, if we want to support both versions, I can update this PR but I kinda don't think it's worth the future maintenance of the script.

@iazel
Copy link

iazel commented Aug 11, 2022

Hi, just chipping in to support this PR. Would be great to have it merged, thank you :)

@JohnCSimon
Copy link
Member

Ping from triage:
@simlay What is the status of this PR? If you're going to abandon this please close the PR. Thank you.

@simlay
Copy link
Contributor Author

simlay commented Oct 3, 2022

Ping from triage:
@simlay What is the status of this PR? If you're going to abandon this please close the PR. Thank you.

This is not abandoned. @Mark-Simulacrum asked about about compatibility. I think I answered sufficiently. Let me know if there's anything more I can do.

@Mark-Simulacrum
Copy link
Member

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 3, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

I'm going to go ahead and merge this, we can rollback if users complain but it seems like a reasonable step to keep compatibility with newer versions given their usage figures (at least to some extent).

@bors
Copy link
Contributor

bors commented Oct 8, 2022

📌 Commit f1ff74f has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 8, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 8, 2022
@bors
Auto merge of rust-lang#102819 - matthiaskrgr:rollup-xwnvofc, r=matth…
f382c27 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#99194 (Fix gdb-cmd for rust-gdbgui)
 - rust-lang#99880 (`EscapeAscii` is not an `ExactSizeIterator`)
 - rust-lang#102524 (rustdoc: remove weird `<a href="#">` wrapper around unsafe triangle)
 - rust-lang#102581 (Make the `config.src` handling for downloadable bootstrap more conservative)
 - rust-lang#102604 (Improve readability of bootstrap's README)
 - rust-lang#102723 (test: run-make: skip when cross-compiling)
 - rust-lang#102815 (rustdoc: remove mobile topbar from source pages instead of hiding it)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3c23567 into rust-lang:master Oct 9, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.

rust-gdbgui error
7 participants
@simlay @rust-highfive @Mark-Simulacrum @iazel @JohnCSimon @bors @rustbot