Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: remove mobile topbar from source pages instead of hiding it #102815

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

notriddle
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @CraftSpider (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 8, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 8, 2022
@notriddle notriddle force-pushed the notriddle/mobile-topbar branch from 814d2bc to d2e14e2 Compare October 8, 2022 17:48
@GuillaumeGomez
Copy link
Member

Can you put an example online please? I'm really surprised that it went for so long.

@notriddle
Copy link
Contributor Author

@GuillaumeGomez
Copy link
Member

This is a really great catch, thanks a lot!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 8, 2022

📌 Commit d2e14e2 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 8, 2022
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#99194 (Fix gdb-cmd for rust-gdbgui)
 - rust-lang#99880 (`EscapeAscii` is not an `ExactSizeIterator`)
 - rust-lang#102524 (rustdoc: remove weird `<a href="#">` wrapper around unsafe triangle)
 - rust-lang#102581 (Make the `config.src` handling for downloadable bootstrap more conservative)
 - rust-lang#102604 (Improve readability of bootstrap's README)
 - rust-lang#102723 (test: run-make: skip when cross-compiling)
 - rust-lang#102815 (rustdoc: remove mobile topbar from source pages instead of hiding it)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9262863 into rust-lang:master Oct 9, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 9, 2022
@notriddle notriddle deleted the notriddle/mobile-topbar branch October 9, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants