Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trait object reborrow suggestion #98277

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Fix trait object reborrow suggestion #98277

merged 2 commits into from
Jun 29, 2022

Conversation

compiler-errors
Copy link
Member

Fixes #93596

Slightly generalizes the logic we use to suggest fix first implemented in #95609, specifically when we have a Sized obligation that comes from a struct's unsized tail.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 20, 2022
@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2022
@compiler-errors
Copy link
Member Author

Also since I'm stashing the concrete type in the obligation cause, why not also note it: 448e00b

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 21, 2022

📌 Commit 448e00b has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 22, 2022
@Dylan-DPC
Rollup merge of rust-lang#98277 - compiler-errors:issue-93596, r=este…
4a72e16 
…bank

Fix trait object reborrow suggestion

Fixes rust-lang#93596

Slightly generalizes the logic we use to suggest fix first implemented in rust-lang#95609, specifically when we have a `Sized` obligation that comes from a struct's unsized tail.
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 22, 2022
Closed
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 23, 2022
@compiler-errors
Rollup merge of rust-lang#98277 - compiler-errors:issue-93596, r=este…
f9b970d 
…bank

Fix trait object reborrow suggestion

Fixes rust-lang#93596

Slightly generalizes the logic we use to suggest fix first implemented in rust-lang#95609, specifically when we have a `Sized` obligation that comes from a struct's unsized tail.
@compiler-errors compiler-errors mentioned this pull request Jun 23, 2022
Closed
@compiler-errors
Copy link
Member Author

@bors r- failed in rollup

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 23, 2022
@compiler-errors
Copy link
Member Author

@bors r=estebank

@bors
Copy link
Contributor

bors commented Jun 24, 2022

📌 Commit 25fe474 has been approved by estebank

@bors bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 24, 2022
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 24, 2022
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 25, 2022
@compiler-errors
Rollup merge of rust-lang#98277 - compiler-errors:issue-93596, r=este…
be2ef3e 
…bank

Fix trait object reborrow suggestion

Fixes rust-lang#93596

Slightly generalizes the logic we use to suggest fix first implemented in rust-lang#95609, specifically when we have a `Sized` obligation that comes from a struct's unsized tail.
@compiler-errors compiler-errors mentioned this pull request Jun 25, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 25, 2022
@Dylan-DPC
Rollup merge of rust-lang#98277 - compiler-errors:issue-93596, r=este…
502083d 
…bank

Fix trait object reborrow suggestion

Fixes rust-lang#93596

Slightly generalizes the logic we use to suggest fix first implemented in rust-lang#95609, specifically when we have a `Sized` obligation that comes from a struct's unsized tail.
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 25, 2022
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 25, 2022
@JohnTitor
Rollup merge of rust-lang#98277 - compiler-errors:issue-93596, r=este…
d0cda3e 
…bank

Fix trait object reborrow suggestion

Fixes rust-lang#93596

Slightly generalizes the logic we use to suggest fix first implemented in rust-lang#95609, specifically when we have a `Sized` obligation that comes from a struct's unsized tail.
@JohnTitor JohnTitor mentioned this pull request Jun 25, 2022
Closed
@matthiaskrgr
Copy link
Member

still failing https://github.com/rust-lang-ci/rust/runs/7053824682?check_suite_focus=true#step:25:20161
@bors r- rollup=iffy

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 25, 2022
@compiler-errors
Copy link
Member Author

@matthiaskrgr, oh it's a windows test. Uh... do you know how one blesses a windows UI test without a windows machine?

@estebank
Copy link
Contributor

@compiler-errors given that it's a single test and only the wording of two notes... I would manually copy the output from CI. 😅

@compiler-errors
Copy link
Member Author

@bors r=estebank

@bors
Copy link
Contributor

bors commented Jun 28, 2022

📌 Commit 862873d has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 28, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 29, 2022
@bors
Auto merge of rust-lang#98656 - Dylan-DPC:rollup-hhytn0c, r=Dylan-DPC
493c960 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#97423 (Simplify memory ordering intrinsics)
 - rust-lang#97542 (Use typed indices in argument mismatch algorithm)
 - rust-lang#97786 (Account for `-Z simulate-remapped-rust-src-base` when resolving remapped paths)
 - rust-lang#98277 (Fix trait object reborrow suggestion)
 - rust-lang#98525 (Add regression test for rust-lang#79224)
 - rust-lang#98549 (interpret: do not prune requires_caller_location stack frames quite so early)
 - rust-lang#98603 (Some borrowck diagnostic fixes)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 57c3cee into rust-lang:master Jun 29, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jun 29, 2022
@compiler-errors compiler-errors deleted the issue-93596 branch August 11, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

Suggest reborrowing unsized value when borrowed trait object wanted
6 participants
@compiler-errors @rust-highfive @estebank @bors @matthiaskrgr @rustbot