Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop emitting E0026 for struct enums with underscores #95238

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Mar 23, 2022

This patch resolves a part of #83263;

r? @estebank

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 23, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2022
@rust-log-analyzer

This comment has been minimized.

@TaKO8Ki TaKO8Ki force-pushed the stop-emitting-E0026-for-struct-enum-with-underscore branch from 6bc8209 to 9b9a80d Compare March 23, 2022 13:33
@rust-log-analyzer

This comment has been minimized.

@TaKO8Ki TaKO8Ki force-pushed the stop-emitting-E0026-for-struct-enum-with-underscore branch from 9b9a80d to 925857d Compare March 23, 2022 13:54
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Mar 23, 2022

📌 Commit 925857d has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2022
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#94249 (Better errors when a Copy impl on a Struct is not self-consistent)
 - rust-lang#95069 (Fix auto traits in rustdoc)
 - rust-lang#95221 (interpret/memory: simplify check_and_deref_ptr)
 - rust-lang#95225 (remove `[async output]` from `impl Future` pretty-printing)
 - rust-lang#95238 (Stop emitting E0026 for struct enums with underscores)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fab7a6a into rust-lang:master Mar 24, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 24, 2022
@TaKO8Ki TaKO8Ki deleted the stop-emitting-E0026-for-struct-enum-with-underscore branch March 24, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants