interpret/memory: simplify check_and_deref_ptr #95221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
check_and_deref_ptr
branch
from
346780d
to
f93a146
Compare
|
@bors r+ I wondered for a sec "how does this work" and then remembered the recent refactorings, and then read your PR comment. Yea... should've probably done these steps in reverse :D |
|
@bors rollup |
|
📌 Commit a76e5b1 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 23, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#94249 (Better errors when a Copy impl on a Struct is not self-consistent) - rust-lang#95069 (Fix auto traits in rustdoc) - rust-lang#95221 (interpret/memory: simplify check_and_deref_ptr) - rust-lang#95225 (remove `[async output]` from `impl Future` pretty-printing) - rust-lang#95238 (Stop emitting E0026 for struct enums with underscores) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally I saw a way to make this code simpler. The odd preprocessing in
let ptr_or_addr =has bothered me since forever, but it actually became unnecessary in the last provenance refactoring. :)This also leads to slightly more explicit error messages as a nice side-effect. 🎉
r? @oli-obk