Rollup of 8 pull requests #94430

matthiaskrgr · 2022-02-27T20:02:46Z

Successful merges:

Fix show error message when literal overflows in match patterns #94354 (Fix show error message when literal overflows in match patterns)
1 - Make more use of let_chains #94396 (1 - Make more use of let_chains)
Document that pre-expansion lint passes are softly deprecated #94397 (Document that pre-expansion lint passes are softly deprecated)
Add test for #79465 to prevent regression #94399 (Add test for ICE: rustdoc on associated-types-path-1.rs attempted .def_id() on invalid res: Err #79465 to prevent regression)
avoid rebuilding bootstrap when PATH changes #94409 (avoid rebuilding bootstrap when PATH changes)
Use the first codegen backend in the config.toml as default #94415 (Use the first codegen backend in the config.toml as default)
Fix duplicated impl links #94417 (Fix duplicated impl links)
3 - Make more use of let_chains #94420 (3 - Make more use of let_chains)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

It is currently hard coded to llvm if enabled and cranelift otherwise. This made some sense when cranelift was the only alternative codegen backend. Since the introduction of the gcc backend this doesn't make much sense anymore. Before this PR bootstrapping rustc using a backend other than llvm or cranelift required changing the source of rustc_interface. With this PR it becomes a matter of putting the right backend as first enabled backend in config.toml.

Continuation of rust-lang#94376. cc rust-lang#53667

Fix show error message when literal overflows in match patterns Fix rust-lang#94239 This changes overflow behavior in [fn lit_to_const](https://github.com/rust-lang/rust/blob/master/compiler/rustc_mir_build/src/thir/constant.rs#L10)

…an-DPC 1 - Make more use of `let_chains` Continuation of rust-lang#94376. cc rust-lang#53667

…ion, r=cjgillot Document that pre-expansion lint passes are softly deprecated The pre-expansion lint pass has been softly deprecated since rust-lang#69838. Every once in a while I see someone mention it as a possibility, only get the feedback that it's deprecated. This PR officially documents that the method is soft deprecated to have a single point of truth for it. That's it. Have a great rest of the day 🙃 --- * See [rust#69838](rust-lang#69838) * See [rust-clippy#5518](rust-lang/rust-clippy#5518)

…5, r=matthiaskrgr Add test for rust-lang#79465 to prevent regression Fixes rust-lang#79465. Like this we will be able to close the issue. r? ```@matthiaskrgr```

avoid rebuilding bootstrap when PATH changes Fixes rust-lang#94408 r? ``@Mark-Simulacrum``

…Simulacrum Use the first codegen backend in the config.toml as default It is currently hard coded to llvm if enabled and cranelift otherwise. This made some sense when cranelift was the only alternative codegen backend. Since the introduction of the gcc backend this doesn't make much sense anymore. Before this PR bootstrapping rustc using a backend other than llvm or cranelift required changing the source of rustc_interface. With this PR it becomes a matter of putting the right backend as first enabled backend in config.toml. cc ``@antoyo``

…links, r=notriddle Fix duplicated impl links Fixes rust-lang#78701. The problem is that the blanket impl has the same ID as the other impl, except that we don't derive IDs when we generate the sidebar. We now do. r? `@notriddle`

3 - Make more use of `let_chains` Continuation of rust-lang#94376. cc rust-lang#53667

matthiaskrgr · 2022-02-27T20:03:00Z

@bors r+ rollup=never p=8

bors · 2022-02-27T20:03:02Z

📌 Commit 8ab2dcc has been approved by matthiaskrgr

bors · 2022-02-27T20:11:33Z

⌛ Testing commit 8ab2dcc with merge 4253cce584af151f38e2569409bd2bd194ac1d48...

rust-log-analyzer · 2022-02-27T20:31:23Z

The job dist-i586-gnu-i586-i686-musl failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Dropping 2
Dropping 3
Dropping 4
------------------------------------------
--- stderr -------------------------------
thread '<unnamed>' panicked at 'Oh no', /checkout/src/test/ui/array-slice-vec/box-of-array-of-drop-1.rs:31:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'expect: 0xffffffff actual: 0x56781234', /checkout/src/test/ui/array-slice-vec/box-of-array-of-drop-1.rs:52:5


---- [ui] ui/array-slice-vec/box-of-array-of-drop-2.rs stdout ----

---
Dropping 2
Dropping 3
Dropping 4
------------------------------------------
--- stderr -------------------------------
thread '<unnamed>' panicked at 'Oh no', /checkout/src/test/ui/array-slice-vec/box-of-array-of-drop-2.rs:31:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'expect: 0xffffffff actual: 0x56781234', /checkout/src/test/ui/array-slice-vec/box-of-array-of-drop-2.rs:52:5


---- [ui] ui/array-slice-vec/nested-vec-3.rs stdout ----

---
Dropping 2
Dropping 3
Dropping 4
------------------------------------------
--- stderr -------------------------------
thread '<unnamed>' panicked at 'Oh no', /checkout/src/test/ui/array-slice-vec/nested-vec-3.rs:32:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'expect: 0xffffffff actual: 0x56781234', /checkout/src/test/ui/array-slice-vec/nested-vec-3.rs:59:5



failures:

bors · 2022-02-27T20:32:21Z

💔 Test failed - checks-actions

light4 and others added 19 commits February 25, 2022 20:00

Fix show error message when literal overflows in match patterns

261765f

fix E0081 error message due to lit_to_const behavior change

5b58c6f

Fix ci test issue-94239.rs

b0c4db3

Document that pre-expansion lint passes are deprecated

2bf56b9

Make more use of let_chains

ca2ad69

Add test for rust-lang#79465 to prevent regression

915740c

avoid rebuilding bootstrap when PATH changes

35e3aaf

Correctly generate links in the sidebar for impls

7e0a2a7

Add test to ensure that links to impls are correctly generated

9b8a6b9

3 - Make more use of let_chains

0eb8b32

Continuation of rust-lang#94376. cc rust-lang#53667

Rollup merge of rust-lang#94396 - c410-f3r:yet-more-let-chains, r=Dyl…

536962d

…an-DPC 1 - Make more use of `let_chains` Continuation of rust-lang#94376. cc rust-lang#53667

Rollup merge of rust-lang#94399 - GuillaumeGomez:regression-test-7946…

fe47628

…5, r=matthiaskrgr Add test for rust-lang#79465 to prevent regression Fixes rust-lang#79465. Like this we will be able to close the issue. r? ```@matthiaskrgr```

Rollup merge of rust-lang#94409 - RalfJung:path, r=Mark-Simulacrum

1bae4d5

avoid rebuilding bootstrap when PATH changes Fixes rust-lang#94408 r? ``@Mark-Simulacrum``

Rollup merge of rust-lang#94420 - c410-f3r:more-let-chains, r=Dylan-DPC

8ab2dcc

3 - Make more use of `let_chains` Continuation of rust-lang#94376. cc rust-lang#53667

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Feb 27, 2022

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 27, 2022

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 27, 2022

bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2022

matthiaskrgr mentioned this pull request Feb 27, 2022

Fix show error message when literal overflows in match patterns #94354

Closed

matthiaskrgr closed this Feb 27, 2022

matthiaskrgr deleted the rollup-80w9cnk branch March 11, 2022 15:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #94430

Rollup of 8 pull requests #94430

matthiaskrgr commented Feb 27, 2022

matthiaskrgr commented Feb 27, 2022

bors commented Feb 27, 2022

bors commented Feb 27, 2022

rust-log-analyzer commented Feb 27, 2022

bors commented Feb 27, 2022

Rollup of 8 pull requests #94430

Rollup of 8 pull requests #94430

Conversation

matthiaskrgr commented Feb 27, 2022

matthiaskrgr commented Feb 27, 2022

bors commented Feb 27, 2022

bors commented Feb 27, 2022

rust-log-analyzer commented Feb 27, 2022

bors commented Feb 27, 2022