Move expr- and item-related pretty printing functions to modules #92920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 94521b7 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 15, 2022
Move expr- and item-related pretty printing functions to modules Currently *compiler/rustc_ast_pretty/src/pprust/state.rs* is 2976 lines on master. The `tidy` limit is 3000, which is blocking rust-lang#92243. This PR adds a `mod expr;` and `mod item;` to move logic related to those AST nodes out of the single huge file.
|
☔ The latest upstream changes (presumably #92970) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
|
|
@bors r=cjgillot |
|
📌 Commit 4556e91d43d019341bf7f3a47822a1a89ebe413c has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #92816) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
|
|
@bors r=cjgillot |
|
📌 Commit 6f8e03f22ab71140656c4895874e029a8b9a7361 has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #87648) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
|
|
@bors r=cjgillot |
|
📌 Commit 07a0325 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 19, 2022
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#88642 (Formally implement let chains) - rust-lang#89621 (doc: guarantee call order for sort_by_cached_key) - rust-lang#91278 (Use iterator instead of recursion in `codegen_place`) - rust-lang#92124 (Little improves in CString `new` when creating from slice) - rust-lang#92783 (Annotate dead code lint with notes about ignored derived impls) - rust-lang#92797 (Remove horizontal lines at top of page) - rust-lang#92920 (Move expr- and item-related pretty printing functions to modules) - rust-lang#93041 (Remove some unused ordering derivations based on `DefId`) - rust-lang#93051 (Add Option::is_some_with and Result::is_{ok,err}_with) - rust-lang#93062 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently compiler/rustc_ast_pretty/src/pprust/state.rs is 2976 lines on master. The
tidylimit is 3000, which is blocking #92243.This PR adds a
mod expr;andmod item;to move logic related to those AST nodes out of the single huge file.