Give types to some bool function arguments in pretty printer

[dtolnay]

I found that the pervasive use of random anonymous bools in the pretty printer made code changes hard to review. Like in the following, it's easy for a reviewer to be inclined to just assume that false and true are correct without tracking down the signature to find out what they mean.

rust/compiler/rustc_ast_pretty/src/pprust/state.rs

Lines 460 to 468 in d6d12b6

	MacArgs::Delimited(_, delim, tokens) => self.print_mac_common(
	Some(MacHeader::Path(&item.path)),
	false,
	None,
	delim.to_token(),
	tokens,
	true,
	span,
	),

This PR replaces all the bool in function signatures in the pretty printer with appropriately named newtype wrappers around bool.

Illustrative example from the code that deals with printing &T / &mut T / &raw const T / &raw mut T:

Before

rust/compiler/rustc_ast_pretty/src/pprust/state.rs

Lines 1915 to 1922 in d6d12b6

	self.word("&");
	match kind {
	ast::BorrowKind::Ref => self.print_mutability(mutability, false),
	ast::BorrowKind::Raw => {
	self.word_nbsp("raw");
	self.print_mutability(mutability, true);
	}
	}

After

https://github.com/rust-lang/rust/blob/fa65008f2fa822c100c10d73ba220f4e4e5352f3/compiler/rustc_ast_pretty/src/pprust/state.rs#L2005-L2012

[rust-highfive]

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

[bors]

☔ The latest upstream changes (presumably #92397) made this pull request unmergeable. Please resolve the merge conflicts.

[dtolnay]

• Rebased to resolve conflict with Remove pretty printer space inside block with only outer attrs #92371

[bors]

☔ The latest upstream changes (presumably #92664) made this pull request unmergeable. Please resolve the merge conflicts.

[dtolnay]

• Rebased to resolve conflict with Remove &self from PrintState::to_string #92336

[rust-log-analyzer]

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

configure: rust.debug-assertions := True
configure: rust.overflow-checks := True
configure: llvm.assertions      := True
configure: dist.missing-tools   := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
* highest error code: E0786
Found 502 error codes
Found 0 error codes with no tests
Done!
tidy error: /checkout/compiler/rustc_ast_pretty/src/pprust/state.rs: too many lines (3006) (add `// ignore-tidy-filelength` to the file to suppress this error)
some tidy checks failed



command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rust-tidy" "/checkout" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build" "16"


Build completed unsuccessfully in 0:00:12

[dtolnay]

Blocked by compiler/rustc_ast_pretty/src/pprust/state.rs being over the 3000 lines tidy limit. I put up #92920 to break it up.

[bors]

☔ The latest upstream changes (presumably #93069) made this pull request unmergeable. Please resolve the merge conflicts.