rustdoc: Only special case struct fields for intra-doc links, not enum variants #92075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
C-cleanup
|
Some changes occurred in intra-doc-links. cc @jyn514 |
rust-highfive
added
the
S-waiting-on-review
jyn514
added a commit
to jyn514/rust
that referenced
this pull request
Dec 18, 2021
jyn514
force-pushed
the
resolve-cleanup
branch
from
ae3ddf1 to
73d20cf
Compare
jyn514
changed the title
camelid
reviewed
Dec 18, 2021
camelid
reviewed
Dec 18, 2021
|
r=me with something like #92075 (comment) addressed |
camelid
added
S-waiting-on-author
jyn514
added
S-waiting-on-review
camelid
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #92088) made this pull request unmergeable. Please resolve the merge conflicts. |
camelid
force-pushed
the
resolve-cleanup
branch
from
d75c37d to
c9a3287
Compare
This comment has been minimized.
This comment has been minimized.
jyn514
commented
Dec 28, 2021
Variants are already handled by `resolve_str_path_error`, rustdoc doesn't need to consider them separately.
camelid
force-pushed
the
resolve-cleanup
branch
from
c9a3287 to
cdd90f8
Compare
|
@bors r+ |
|
📌 Commit cdd90f8c17e9cbbf05a2d420b9c9605d55f3a9eb has been approved by |
bors
added
S-waiting-on-bors
|
@bors r- |
bors
added
S-waiting-on-author
camelid
force-pushed
the
resolve-cleanup
branch
from
cdd90f8 to
a689577
Compare
camelid
force-pushed
the
resolve-cleanup
branch
from
a689577 to
09104ad
Compare
|
@bors r+ |
|
📌 Commit 09104ad has been approved by |
bors
added
S-waiting-on-bors
|
I updated the comment. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 29, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#92075 (rustdoc: Only special case struct fields for intra-doc links, not enum variants) - rust-lang#92118 (Parse and suggest moving where clauses after equals for type aliases) - rust-lang#92237 (Visit expressions in-order when resolving pattern bindings) - rust-lang#92340 (rustdoc: Start cleaning up search index generation) - rust-lang#92351 (Add long error explanation for E0227) - rust-lang#92371 (Remove pretty printer space inside block with only outer attrs) - rust-lang#92372 (Print space after formal generic params in fn type) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variants are already handled by
resolve_str_path_error, rustdoc doesn't need to consider them separately. Thanks @camelid for catching this!Eventually I'd like to fix the "combine this with
variant_field" comment but that needsresolve_fieldto take aty_resparameter to avoid it being super hacky (cc #83761 (comment)).r? @camelid